[PATCH] Fix --show-commands.

Chris Johns chrisj at rtems.org
Fri Jun 8 13:35:32 UTC 2018



> On 8 Jun 2018, at 4:21 pm, Christian Mauderer <christian.mauderer at embedded-brains.de> wrote:
> 
>> Am 06.06.2018 um 09:48 schrieb Christian Mauderer:
>> In the current version of libbsd, if the --show-commands option is used,
>> the cwd is passed as a Nod3. Popen does not work with that. Therefore
>> create a string from cwd if it isn't already.
>> ---
>> rtems.py | 2 ++
>> 1 file changed, 2 insertions(+)
>> 
>> diff --git a/rtems.py b/rtems.py
>> index 6907709..a88c679 100644
>> --- a/rtems.py
>> +++ b/rtems.py
>> @@ -579,6 +579,8 @@ def output_command_line():
>>         else:
>>             cmdstr = ' '.join(cmd)
>>             Logs.info('(%d) %s' % (len(cmdstr), cmdstr)) # here is the change
>> +        if not isinstance(kw['cwd'], str):
>> +            kw['cwd'] = str(kw['cwd'])
>>         Logs.debug('runner_env: kw=%s' % kw)
>>         try:
>>             if self.logger:
>> 
> 
> Hello Chris,
> 
> do you see any problems with that patch?
> 

The patch is fine. I have not had time to merge it, I am still catching up.

> Please note that this is for your personal rtems_waf.git repo. So I
> can't check it in even if it would be acceptable. But if it is OK for
> you, I'll create and commit a patch for libbsd to use the new version as
> soon as this patch is commited.

Thanks. 

Chris




More information about the devel mailing list