[PATCH 1/3] i386/smp: Define unused CPU_Interrupt_frame to fix compiler error

[Joel Sherrill]

On Mar 12, 2018 7:40 AM, "Amaan Cheval" <amaan.cheval at gmail.com> wrote:

Agreed. I'll look into fixing CPU_Interrupt_frame up as time permits.


If you get it to compile before addressing the context switch
synchronization point, one thought is to put an ifdef RTEMS_SMP with a
#error where the fix needs to go with the message referencing the ticket
number.

At least that way, it still doesn't compile until that issue is also fixed.
As Sebastian said, that failure is more subtle than a compile error.


Appreciate the help and follow-ups, thanks!

On Mon, Mar 12, 2018 at 6:06 PM Sebastian Huber <
sebastian.huber at embedded-brains.de> wrote:

> On 12/03/18 13:32, Amaan Cheval wrote:
> > I originally sent this patch with the intent of merely ridding the i386
> > targets of compiler errors, for anyone interested in looking into SMP
> > issues on the arch.
> >
> > Do you believe that I should look into fixing i386's incomplete SMP
> > context-switch support for this patch too, or would that be okay as a
> > follow-up later, given that it seems like there's more incompleteness
> > regarding SMP for i386?

> A compile-time error is a good hint that it is broken. I think this is
> more user friendly compared to having to debug a run-time error which
> takes place only under certain conditions.

> --
> Sebastian Huber, embedded brains GmbH

> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone   : +49 89 189 47 41-16
> Fax     : +49 89 189 47 41-09
> E-Mail  : sebastian.huber at embedded-brains.de
> PGP     : Public key available on request.

> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
_______________________________________________
devel mailing list
devel at rtems.org
http://lists.rtems.org/mailman/listinfo/devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20180312/f31beac8/attachment.html>