[PATCH] bsp/atsam: Fix GMAC Rx Descriptor fields.

[Christian Mauderer]

----- Ursprüngliche Mail -----
> Von: "Gedare Bloom" <gedare at rtems.org>
> An: "Christian Mauderer" <christian.mauderer at embedded-brains.de>
> CC: "RTEMS Devel" <devel at rtems.org>
> Gesendet: Freitag, 16. März 2018 15:08:39
> Betreff: Re: [PATCH] bsp/atsam: Fix GMAC Rx Descriptor fields.

> On Wed, Mar 14, 2018 at 10:51 AM, Christian Mauderer
> <christian.mauderer at embedded-brains.de> wrote:
>> ---
>>  bsps/arm/atsam/include/libchip/include/gmac.h | 15 +++++++++------
>>  1 file changed, 9 insertions(+), 6 deletions(-)
>>
>> diff --git a/bsps/arm/atsam/include/libchip/include/gmac.h
>> b/bsps/arm/atsam/include/libchip/include/gmac.h
>> index 64e0079c25..a4227920bd 100644
>> --- a/bsps/arm/atsam/include/libchip/include/gmac.h
>> +++ b/bsps/arm/atsam/include/libchip/include/gmac.h
>> @@ -186,13 +186,16 @@ typedef struct _GmacRxDescriptor {
>>                                          vlanPriority: 3,       /** VLAN priority (if VLAN detected) */
>>                                          bPriorityDetected: 1,  /** Priority tag detected */
>>                                          bVlanDetected: 1,      /**< VLAN tag detected */
>> -                                        bTypeIDMatch: 1,       /**< Type ID
>> match */
>> -                                        bAddr4Match: 1,        /**< Address
>> register 4 match */
>> -                                        bAddr3Match: 1,        /**< Address
>> register 3 match */
>> -                                        bAddr2Match: 1,        /**< Address
>> register 2 match */
>> -                                        bAddr1Match: 1,        /**< Address
>> register 1 match */
>> +                                        typeIDMatchOrCksumResult: 2,
>> +#define   GMAC_RXDESC_ST_CKSUM_RESULT_NOT_CHECKED        (0)
>> +#define   GMAC_RXDESC_ST_CKSUM_RESULT_IP_CHECKED         (1)
>> +#define   GMAC_RXDESC_ST_CKSUM_RESULT_IP_AND_TCP_CHECKED (2)
>> +#define   GMAC_RXDESC_ST_CKSUM_RESULT_IP_AND_UDP_CHECKED (3)
>> +
> 
> I find these #define in the middle of a struct definition quite
> irregular. Is there a compelling reason they go here, or can they go
> outside the struct?

I wanted to locate the defines near the field where they should be used. But I don't have a strong opinion about that. I'll put them outside of the structure and re-send a V2 patch on Monday.

> 
>> +                                        bTypeIDMatchFoundOrCksumSNAPState: 1,
>> +                                        specAddrMatchRegister: 2,
>> +                                        bSpecAddrMatchFound: 1,
>>                                          reserved: 1,
>> -                                        bExtAddrMatch: 1,      /**< External
>> address match */
>>                                          bUniHashMatch: 1,      /**< Unicast hash match */
>>                                          bMultiHashMatch: 1,    /**< Multicast hash match */
>>                                          bBroadcastDetected: 1;  /**< Global all ones broadcast
>> --
>> 2.13.6
>>
>> _______________________________________________
>> devel mailing list
>> devel at rtems.org
> > http://lists.rtems.org/mailman/listinfo/devel

-- 
--------------------------------------------
embedded brains GmbH
Christian Mauderer
Dornierstr. 4
D-82178 Puchheim
Germany
email: christian.mauderer at embedded-brains.de
Phone: +49-89-18 94 741 - 18
Fax:   +49-89-18 94 741 - 08
PGP: Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.