[PATCH 11/11] score: add Inherited_priorities priority queue and functions
Gedare Bloom
gedare at rtems.org
Fri Mar 23 16:15:47 UTC 2018
Adds enqueue, dequeue, requeue, evaluate, and release functions
for the thread priority node priority queue of inherited priorities.
Add calls to these functions as needed to maintain the priority
queue due to blocking, unblocking, and priority changes.
Closes #3359.
---
cpukit/rtems/src/tasksetpriority.c | 4 +-
cpukit/score/Makefile.am | 3 +-
cpukit/score/include/rtems/score/coremutex.h | 2 +-
cpukit/score/include/rtems/score/thread.h | 63 +++++++++-
cpukit/score/src/coremutexseize.c | 9 +-
cpukit/score/src/coremutexsurrender.c | 6 +-
cpukit/score/src/threadchangepriority.c | 4 +-
cpukit/score/src/threadinitialize.c | 6 +-
cpukit/score/src/threadprioritynode.c | 167 +++++++++++++++++++++++++++
cpukit/score/src/threadqextractpriority.c | 5 +
cpukit/score/src/threadqflush.c | 6 +
cpukit/score/src/threadreset.c | 16 +++
12 files changed, 272 insertions(+), 19 deletions(-)
create mode 100644 cpukit/score/src/threadprioritynode.c
diff --git a/cpukit/rtems/src/tasksetpriority.c b/cpukit/rtems/src/tasksetpriority.c
index 6f365f4..2b5b062 100644
--- a/cpukit/rtems/src/tasksetpriority.c
+++ b/cpukit/rtems/src/tasksetpriority.c
@@ -75,9 +75,7 @@ rtems_status_code rtems_task_set_priority(
*old_priority = the_thread->Priority_node.current_priority;
if ( new_priority != RTEMS_CURRENT_PRIORITY ) {
the_thread->Priority_node.real_priority = new_priority;
- if ( the_thread->resource_count == 0 ||
- the_thread->Priority_node.current_priority > new_priority )
- _Thread_Change_priority( the_thread, new_priority, false );
+ _Thread_Evaluate_priority( the_thread );
}
_Thread_Enable_dispatch();
return RTEMS_SUCCESSFUL;
diff --git a/cpukit/score/Makefile.am b/cpukit/score/Makefile.am
index c61e1dc..06d3234 100644
--- a/cpukit/score/Makefile.am
+++ b/cpukit/score/Makefile.am
@@ -154,7 +154,8 @@ libscore_a_SOURCES += src/thread.c src/threadchangepriority.c \
src/threadstackallocate.c src/threadstackfree.c src/threadstart.c \
src/threadstartmultitasking.c src/threadsuspend.c \
src/threadtickletimeslice.c src/threadyieldprocessor.c \
- src/iterateoverthreads.c src/threadblockingoperationcancel.c
+ src/iterateoverthreads.c src/threadblockingoperationcancel.c \
+ src/threadprioritynode.c
## THREAD_C_FILES only used by ITRON API
if LIBITRON
diff --git a/cpukit/score/include/rtems/score/coremutex.h b/cpukit/score/include/rtems/score/coremutex.h
index ba2ae02..25d6f48 100644
--- a/cpukit/score/include/rtems/score/coremutex.h
+++ b/cpukit/score/include/rtems/score/coremutex.h
@@ -216,7 +216,7 @@ typedef struct {
*
* The following defines the control block used to manage each mutex.
*/
-typedef struct {
+typedef struct CORE_mutex_Control {
/** This field is the Waiting Queue used to manage the set of tasks
* which are blocked waiting to lock the mutex.
*/
diff --git a/cpukit/score/include/rtems/score/thread.h b/cpukit/score/include/rtems/score/thread.h
index b0b40f7..4c51977 100644
--- a/cpukit/score/include/rtems/score/thread.h
+++ b/cpukit/score/include/rtems/score/thread.h
@@ -276,15 +276,23 @@ typedef struct {
Thread_queue_Control *queue;
} Thread_Wait_information;
+struct CORE_mutex_Control;
/**
* @brief Encapsulates base and inherited priority.
*/
typedef struct Thread_Priority_node {
- Chain_Node Node;
+ Chain_Node Node;
/** current priority = min(real_priority, min(Inherited_priorities)) */
- Priority_Control current_priority;
+ Priority_Control current_priority;
/** base priority irrespective of inheritance/ceiling */
- Priority_Control real_priority;
+ Priority_Control real_priority;
+ /** NULL if not waiting, or the mutex blocked upon
+ * if waiting. If not NULL, then this Priority_node is on the mutex holder's
+ * Priority_node.Inherited_priorities list. */
+ struct CORE_mutex_Control *waiting_to_hold;
+ /** Priority Queue of thread Priority_nodes blocked by this one, thus
+ * possibly contributing their priority to the current_priority. */
+ Chain_Control Inherited_priorities;
} Thread_Priority_node;
/**
@@ -787,6 +795,55 @@ void _Thread_Resume(
*/
bool _Thread_Evaluate_mode( void );
+/**
+ * This routine sets the thread's priority_node->current_priority to the
+ * minimum of the real_priority and the first node of Inherited_priorities,
+ * if any.
+ */
+void _Thread_Evaluate_priority(
+ Thread_Control *the_thread
+);
+
+/**
+ * This routine adds a thread's Priority_node to the mutex holder's
+ * Inherited_priorities list, and sets the waiting_to_hold field to the
+ * mutex.
+ *
+ * Returns true if the enqueued node is at the head of the holder's
+ * Inherited priorities, and therefore the holder's priority may change.
+ */
+bool _Thread_Enqueue_priority_node(
+ Thread_Control *the_thread,
+ struct CORE_mutex_Control *the_mutex
+);
+
+/**
+ * This routine removes a thread's Priority_node from an
+ * Inherited_priorities list, updates the mutex holder's
+ * current_priority if needed, and clears the mutex field.
+ *
+ * Returns the mutex that the thread was waiting on.
+ */
+struct CORE_mutex_Control* _Thread_Dequeue_priority_node(
+ Thread_Priority_node *thread_pn
+);
+
+/**
+ * This routine updates the position of a thread's Priority_node in an
+ * Inherited_priorities list if on one.
+ */
+void _Thread_Requeue_priority_node(
+ Thread_Control *the_thread
+);
+
+/**
+ * This routine removes the inherited priorities from the mutex being
+ * released and updates the holder's priority if necessary.
+ */
+void _Thread_Release_inherited_priority(
+ struct CORE_mutex_Control *the_mutex
+);
+
#if (CPU_PROVIDES_IDLE_THREAD_BODY == FALSE)
/**
* This routine is the body of the system idle thread.
diff --git a/cpukit/score/src/coremutexseize.c b/cpukit/score/src/coremutexseize.c
index c19d868..dace213 100644
--- a/cpukit/score/src/coremutexseize.c
+++ b/cpukit/score/src/coremutexseize.c
@@ -61,13 +61,8 @@ void _CORE_mutex_Seize_interrupt_blocking(
executing = _Thread_Executing;
if ( _CORE_mutex_Is_inherit_priority( &the_mutex->Attributes ) ) {
- if ( the_mutex->holder->Priority_node.current_priority > executing->Priority_node.current_priority ) {
- _Thread_Change_priority(
- the_mutex->holder,
- executing->Priority_node.current_priority,
- false
- );
- }
+ _Thread_Enqueue_priority_node( executing, the_mutex );
+ _Thread_Evaluate_priority( the_mutex->holder );
}
the_mutex->blocked_count++;
diff --git a/cpukit/score/src/coremutexsurrender.c b/cpukit/score/src/coremutexsurrender.c
index 2ed2afe..56d5045 100644
--- a/cpukit/score/src/coremutexsurrender.c
+++ b/cpukit/score/src/coremutexsurrender.c
@@ -124,6 +124,9 @@ CORE_mutex_Status _CORE_mutex_Surrender(
#endif
holder->resource_count--;
}
+ if ( _CORE_mutex_Is_inherit_priority( &the_mutex->Attributes ) ) {
+ _Thread_Release_inherited_priority( the_mutex );
+ }
the_mutex->holder = NULL;
the_mutex->holder_id = 0;
@@ -132,8 +135,7 @@ CORE_mutex_Status _CORE_mutex_Surrender(
* inherited priority must be lowered if this is the last
* mutex (i.e. resource) this task has.
*/
- if ( _CORE_mutex_Is_inherit_priority( &the_mutex->Attributes ) ||
- _CORE_mutex_Is_priority_ceiling( &the_mutex->Attributes ) ) {
+ if ( _CORE_mutex_Is_priority_ceiling( &the_mutex->Attributes ) ) {
#ifdef __RTEMS_STRICT_ORDER_MUTEX__
if(the_mutex->queue.priority_before != holder->Priority_node.current_priority)
_Thread_Change_priority(holder,the_mutex->queue.priority_before,true);
diff --git a/cpukit/score/src/threadchangepriority.c b/cpukit/score/src/threadchangepriority.c
index d109dd9..c3dc3ff 100644
--- a/cpukit/score/src/threadchangepriority.c
+++ b/cpukit/score/src/threadchangepriority.c
@@ -88,8 +88,10 @@ void _Thread_Change_priority(
* Do not bother recomputing all the priority related information if
* we are not REALLY changing priority.
*/
- if ( the_thread->Priority_node.current_priority != new_priority )
+ if ( the_thread->Priority_node.current_priority != new_priority ) {
_Thread_Set_priority( the_thread, new_priority );
+ _Thread_Requeue_priority_node( the_thread );
+ }
_ISR_Disable( level );
diff --git a/cpukit/score/src/threadinitialize.c b/cpukit/score/src/threadinitialize.c
index a02c729..3fda5ea 100644
--- a/cpukit/score/src/threadinitialize.c
+++ b/cpukit/score/src/threadinitialize.c
@@ -192,7 +192,11 @@ bool _Thread_Initialize(
#if defined(RTEMS_ITRON_API)
the_thread->suspend_count = 0;
#endif
- the_thread->Priority_node.real_priority = priority;
+ _Chain_Set_off_chain( &the_thread->Priority_node.Node );
+ the_thread->Priority_node.real_priority = priority;
+ the_thread->Priority_node.current_priority = priority;
+ the_thread->Priority_node.waiting_to_hold = NULL;
+ _Chain_Initialize_empty( &the_thread->Priority_node.Inherited_priorities );
the_thread->Start.initial_priority = priority;
_Thread_Set_priority( the_thread, priority );
diff --git a/cpukit/score/src/threadprioritynode.c b/cpukit/score/src/threadprioritynode.c
new file mode 100644
index 0000000..69bbe14
--- /dev/null
+++ b/cpukit/score/src/threadprioritynode.c
@@ -0,0 +1,167 @@
+/*
+ * Thread Priority Node
+ *
+ * Copyright (C) 2017. Gedare Bloom.
+ *
+ * The license and distribution terms for this file may be
+ * found in the file LICENSE in this distribution or at
+ * http://www.rtems.org/license/LICENSE.
+ */
+
+#if HAVE_CONFIG_H
+#include "config.h"
+#endif
+
+#include <rtems/system.h>
+#include <rtems/config.h>
+#include <rtems/score/chain.h>
+#include <rtems/score/coremutex.h>
+#include <rtems/score/thread.h>
+
+/**
+ * This routine adds a thread's Priority_node to the mutex holder's
+ * Inherited_priorities list, and sets the waiting_to_hold field to the
+ * mutex.
+ *
+ * Returns true if the enqueued node is at the head of the holder's
+ * Inherited priorities, and therefore the holder's priority may change.
+ */
+bool _Thread_Enqueue_priority_node(
+ Thread_Control *the_thread,
+ CORE_mutex_Control *the_mutex
+)
+{
+ Chain_Node *iter;
+ Thread_Priority_node *thread_pn, *holder_pn;
+ Priority_Control task_priority, iter_priority;
+
+ thread_pn = &the_thread->Priority_node;
+ holder_pn = &the_mutex->holder->Priority_node;
+
+ thread_pn->waiting_to_hold = the_mutex;
+ iter = holder_pn->Inherited_priorities.first;
+ task_priority = thread_pn->current_priority;
+
+ /* Find the first node in holder's Inherited_priorities list with
+ * lower priority than the task, or find the end of the list. */
+ while ( !_Chain_Is_tail( &holder_pn->Inherited_priorities, iter) ) {
+ iter_priority = ((Thread_Priority_node *)iter)->current_priority;
+ if ( iter_priority > task_priority ) {
+ break;
+ }
+ iter = _Chain_Next( iter );
+ }
+ _Chain_Insert_unprotected( _Chain_Previous( iter ), &thread_pn->Node );
+
+ /* If the_thread is at the start of the holder's Inherited_priorites list,
+ * then may need to update the holder's current priority. */
+ if ( _Chain_Is_first( &thread_pn->Node ) ) {
+ return true;
+ }
+ return false;
+}
+
+/**
+ * This routine sets the thread's priority_node->current_priority to the
+ * minimum of the real_priority and the first node of Inherited_priorities,
+ * if any.
+ */
+void _Thread_Evaluate_priority(
+ Thread_Control *the_thread
+)
+{
+ Chain_Node *first;
+ Thread_Priority_node *first_pn, *priority_node;
+ Priority_Control current_priority, min_priority;
+
+ /* Start with the_thread, and iterate through the holder threads that
+ * the_thread is waiting on. If any thread's priority does not change,
+ * then stop iterating. */
+ while ( the_thread != NULL ) {
+ priority_node = &the_thread->Priority_node;
+ current_priority = priority_node->current_priority;
+ min_priority = priority_node->real_priority;
+ first = _Chain_First( &priority_node->Inherited_priorities );
+ if ( !_Chain_Is_tail( &priority_node->Inherited_priorities, first ) ) {
+ first_pn = (Thread_Priority_node *)first;
+ if ( min_priority > first_pn->current_priority ) {
+ min_priority = first_pn->current_priority;
+ }
+ }
+ if ( current_priority < min_priority ) {
+ _Thread_Change_priority( the_thread, min_priority, true );
+ } else if ( current_priority > min_priority ) {
+ _Thread_Change_priority( the_thread, min_priority, false );
+ } else {
+ break;
+ }
+ if ( the_thread->Priority_node.waiting_to_hold != NULL ) {
+ the_thread = the_thread->Priority_node.waiting_to_hold->holder;
+ } else {
+ the_thread = NULL;
+ }
+ }
+}
+
+/**
+ * This routine removes a thread's Priority_node from an
+ * Inherited_priorities list, updates the mutex holder's
+ * current_priority if needed, and clears the mutex field.
+ *
+ * Returns the mutex that the_thread was waiting on.
+ */
+CORE_mutex_Control* _Thread_Dequeue_priority_node(
+ Thread_Priority_node *thread_pn
+)
+{
+ CORE_mutex_Control *the_mutex = thread_pn->waiting_to_hold;
+
+ if ( the_mutex == NULL ) {
+ return NULL;
+ }
+
+ _Chain_Extract_unprotected( &thread_pn->Node );
+ thread_pn->waiting_to_hold = NULL;
+
+ return the_mutex;
+}
+
+void _Thread_Requeue_priority_node(
+ Thread_Control *the_thread
+)
+{
+ ISR_Level level;
+ CORE_mutex_Control *mutex;
+
+ _ISR_Disable( level );
+ /* TODO: refactor? */
+ mutex = _Thread_Dequeue_priority_node( &the_thread->Priority_node );
+ if ( mutex != NULL ) {
+ _Thread_Enqueue_priority_node( the_thread, mutex );
+ }
+ _ISR_Enable( level );
+}
+
+/**
+ * This routine removes the inherited priorities from the mutex being
+ * released and updates the holder's priority if necessary.
+ */
+void _Thread_Release_inherited_priority(
+ CORE_mutex_Control *the_mutex
+)
+{
+ Chain_Control *ip = &the_mutex->holder->Priority_node.Inherited_priorities;
+ Chain_Node *cn;
+ Thread_Priority_node *tpn;
+
+ for (cn = _Chain_First(ip); !_Chain_Is_tail(ip, cn); cn = _Chain_Next(cn)) {
+ tpn = (Thread_Priority_node*)cn;
+ if ( tpn->waiting_to_hold == the_mutex ) {
+ _Chain_Extract(cn);
+ tpn->waiting_to_hold = NULL;
+ }
+ }
+
+ _Thread_Evaluate_priority( the_mutex->holder );
+}
+
diff --git a/cpukit/score/src/threadqextractpriority.c b/cpukit/score/src/threadqextractpriority.c
index f314f75..5c8188d 100644
--- a/cpukit/score/src/threadqextractpriority.c
+++ b/cpukit/score/src/threadqextractpriority.c
@@ -18,6 +18,7 @@
#include <rtems/system.h>
#include <rtems/score/chain.h>
+#include <rtems/score/coremutex.h>
#include <rtems/score/isr.h>
#include <rtems/score/object.h>
#include <rtems/score/states.h>
@@ -57,6 +58,7 @@ bool _Thread_queue_Extract_priority_helper(
Chain_Node *new_first_node;
Chain_Node *new_second_node;
Chain_Node *last_node;
+ CORE_mutex_Control *mutex;
the_node = (Chain_Node *) the_thread;
_ISR_Disable( level );
@@ -106,6 +108,9 @@ bool _Thread_queue_Extract_priority_helper(
return true;
}
+ mutex = _Thread_Dequeue_priority_node( &the_thread->Priority_node );
+ _Thread_Evaluate_priority( mutex->holder );
+
if ( !_Watchdog_Is_active( &the_thread->Timer ) ) {
_ISR_Enable( level );
} else {
diff --git a/cpukit/score/src/threadqflush.c b/cpukit/score/src/threadqflush.c
index b777aa3..47bff88 100644
--- a/cpukit/score/src/threadqflush.c
+++ b/cpukit/score/src/threadqflush.c
@@ -18,6 +18,7 @@
#include <rtems/system.h>
#include <rtems/score/chain.h>
+#include <rtems/score/coremutex.h>
#include <rtems/score/isr.h>
#include <rtems/score/object.h>
#include <rtems/score/states.h>
@@ -50,6 +51,7 @@ void _Thread_queue_Flush(
)
{
Thread_Control *the_thread;
+ CORE_mutex_Control *mutex;
while ( (the_thread = _Thread_queue_Dequeue( the_thread_queue )) ) {
#if defined(RTEMS_MULTIPROCESSING)
@@ -58,5 +60,9 @@ void _Thread_queue_Flush(
else
#endif
the_thread->Wait.return_code = status;
+ if ( the_thread->Priority_node.waiting_to_hold != NULL ) {
+ mutex = _Thread_Dequeue_priority_node( &the_thread->Priority_node );
+ _Thread_Evaluate_priority( mutex->holder );
+ }
}
}
diff --git a/cpukit/score/src/threadreset.c b/cpukit/score/src/threadreset.c
index fd55ca3..464a611 100644
--- a/cpukit/score/src/threadreset.c
+++ b/cpukit/score/src/threadreset.c
@@ -19,6 +19,7 @@
#include <rtems/system.h>
#include <rtems/score/apiext.h>
#include <rtems/score/context.h>
+#include <rtems/score/coremutex.h>
#include <rtems/score/interr.h>
#include <rtems/score/isr.h>
#include <rtems/score/object.h>
@@ -46,6 +47,8 @@ void _Thread_Reset(
Thread_Entry_numeric_type numeric_argument
)
{
+ CORE_mutex_Control *mutex;
+
the_thread->resource_count = 0;
#if defined(RTEMS_ITRON_API)
the_thread->suspend_count = 0;
@@ -63,6 +66,19 @@ void _Thread_Reset(
(void) _Watchdog_Remove( &the_thread->Timer );
}
+ if ( the_thread->Priority_node.waiting_to_hold != NULL ) {
+ mutex = _Thread_Dequeue_priority_node( &the_thread->Priority_node );
+ _Thread_Evaluate_priority( mutex->holder );
+ }
+
+ while ( !_Chain_Is_empty( &the_thread->Priority_node.Inherited_priorities ) ) {
+ _Thread_Dequeue_priority_node(
+ ((Thread_Priority_node*)_Chain_First(
+ &the_thread->Priority_node.Inherited_priorities
+ ))
+ );
+ }
+
if ( the_thread->Priority_node.current_priority != the_thread->Start.initial_priority ) {
the_thread->Priority_node.real_priority = the_thread->Start.initial_priority;
_Thread_Set_priority( the_thread, the_thread->Start.initial_priority );
--
2.7.4
More information about the devel
mailing list