[PATCH] score: Simplify _Objects_Name_to_string()

Sebastian Huber sebastian.huber at embedded-brains.de
Fri May 25 12:13:31 UTC 2018


Do not use isprint() from <ctype.h> since it depends on the heavy weight
C locale implementation in Newlib.
---
 cpukit/score/src/objectgetnameasstring.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/cpukit/score/src/objectgetnameasstring.c b/cpukit/score/src/objectgetnameasstring.c
index 7a6177a124..f23b1599e1 100644
--- a/cpukit/score/src/objectgetnameasstring.c
+++ b/cpukit/score/src/objectgetnameasstring.c
@@ -21,7 +21,17 @@
 
 #include <rtems/score/threadimpl.h>
 
-#include <ctype.h>
+/*
+ * Do not use isprint() from <ctypes.h> since this depends on the heavy weight
+ * C locale support of Newlib.
+ */
+static bool _Objects_Name_char_is_printable( char c )
+{
+  unsigned char uc;
+
+  uc = (unsigned char) c;
+  return uc >= ' ' && uc <= '~';
+}
 
 size_t _Objects_Name_to_string(
   Objects_Name  name,
@@ -55,7 +65,7 @@ size_t _Objects_Name_to_string(
   if ( s != NULL ) {
     while ( *s != '\0' ) {
       if ( i < buffer_size ) {
-        *d = isprint((unsigned char) *s) ? *s : '*';
+        *d = _Objects_Name_char_is_printable(*s) ? *s : '*';
         ++d;
       }
 
-- 
2.13.6



More information about the devel mailing list