[PATCH 1/2] dhcpcd: Add rtems_dhcpcd_start()

[Joel Sherrill]

On Wed, May 2, 2018, 4:35 AM Sebastian Huber <
sebastian.huber at embedded-brains.de> wrote:

> On 02/05/18 11:01, Chris Johns wrote:
> > This is duplicating this code:
> >
> >
> https://git.rtems.org/rtems-libbsd/tree/rtemsbsd/rtems/rtems-bsd-rc-conf-net.c#n632
> >
> > It is a documented way to run DHCP [1].
>
> The FreeBSD compatible initialization is nice, but not every application
> should be forced to use the rc.conf based initialization approach.
>

I have to disagree. We don't need multiple ways of initializating something.

The value of following the FreeBSD model is high.

>
> >
> > The change no documentation and seems rather custom. This approach was a
> flaw
> > with the legacy stack and I would prefer we do not follow. It allows
> > applications to be created that use it which means we need to maintain
> this forever.
>
> It is a simple refactorization of the default-network-init.h code. For
> some applications this is just the right thing to do.
>
> In terms of libbsd documentation, yes, this is an open issue in general.
> Its likely more than one week of work which I don't have at the moment.
>

That's just unfortunate and not a good reason to take shortcuts.

>
> --
> Sebastian Huber, embedded brains GmbH
>
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone   : +49 89 189 47 41-16
> Fax     : +49 89 189 47 41-09
> E-Mail  : sebastian.huber at embedded-brains.de
> PGP     : Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20180503/9731bf61/attachment-0002.html>