Warning Flags Disappeared

[Chris Johns]

On 8/5/18 5:17 pm, Sebastian Huber wrote:
> This change adds the warning flags. I don't know why CFLAGS is now present.

What do you mean by this last sentence?

> There could be a problem somewhere else.

The support was added back in 2011 )d71462b4eb38efbcda6d429a0a61749d7a89e195).

I moved this:

 # Was CFLAGS set?
 rtems_cv_CFLAGS_set="${CFLAGS+set}"

into aclocal/rtems-includes.m4 in the preinstall removal.

Chris

> 
> diff --git a/c/src/configure.ac b/c/src/configure.ac
> index f4428ed221..7e4986e03d 100644
> --- a/c/src/configure.ac
> +++ b/c/src/configure.ac
> @@ -100,7 +100,7 @@ RTEMS_PROG_CCAS
>  RTEMS_CANONICALIZE_TOOLS
> 
>  # Append warning flags if CFLAGS wasn't set.
> -AS_IF([test "$GCC" = yes && test "$rtems_cv_CFLAGS_set" != set],
> +AS_IF([test "$GCC" = yes],
>  [CFLAGS="$CFLAGS -Wall -Wmissing-prototypes -Wimplicit-function-declaration
> -Wstrict-prototypes -Wnested-externs"])
> 
>  AS_IF([test -n "${CFLAGS}"],[
> 
> On 19/04/18 15:18, Sebastian Huber wrote:
>> The problem is in c/src/configure.ac:
>>
>> # Was CFLAGS set?
>> rtems_cv_CFLAGS_set="${CFLAGS+set}"
>>
>> In this line CFLAGS is set. Later we have:
>>
>> # Append warning flags if CFLAGS wasn't set.
>> AS_IF([test "$GCC" = yes && test "$rtems_cv_CFLAGS_set" != set],
>> [CFLAGS="$CFLAGS -Wall -Wmissing-prototypes -Wimplicit-function-declaration
>> -Wstrict-prototypes -Wnested-externs"])
>>
>