[PATCH] covoar: fixing the extension mismatch in trace file

[Vijay Kumar Banerjee]

On Sun, 13 May 2018, 10:09 Chris Johns, <chrisj at rtems.org> wrote:

> Sorry for the post in the other thread. I did not see this one.
>
> On 13/5/18 9:28 am, Joel Sherrill wrote:
> >
> >
> > On Sat, May 12, 2018 at 2:42 PM, thelunatic <vijaykumar9597 at gmail.com
> > <mailto:vijaykumar9597 at gmail.com>> wrote:
> >
> >     ---
> >
> >
> > Every patch needs an explanation/log message.  Look back through
> > "git log" for examples.
> >
> >
> >      tester/covoar/covoar.cc | 7 ++++---
> >      1 file changed, 4 insertions(+), 3 deletions(-)
> >
> >     diff --git a/tester/covoar/covoar.cc b/tester/covoar/covoar.cc
> >     index 5bed98f..95dc990 100644
> >     --- a/tester/covoar/covoar.cc
> >     +++ b/tester/covoar/covoar.cc
> >     @@ -185,7 +185,7 @@ int main(
> >        Executables                   executablesToAnalyze;
> >        Coverage::ExecutableInfo*     executableInfo = NULL;
> >        std::string                   executableExtension = "exe";
> >     -  std::string                   coverageExtension = "cov";
> >     +  std::string                   coverageExtension = ".cov";
> >
> >
> > Why did this need a "." but the "exe" one didn't?
> >
>
> Yes I was wondering this and why I made the change to the coverage
> extension.
>
> >
> >        Coverage::CoverageFormats_t   coverageFormat =
> >     Coverage::COVERAGE_FORMAT_QEMU;
> >        Coverage::CoverageReaderBase* coverageReader = NULL;
> >        char*                         executable = NULL;
> >     @@ -317,11 +317,12 @@ int main(
> >              std::cerr << "warning: Unable to read executable: " <<
> argv[i] <<
> >     std::endl;
> >            } else {
> >              coverageFileName = argv[i];
> >     -        coverageFileName.replace(
> >     +       coverageFileName.append(coverageExtension);
> >     +     /* coverageFileName.replace(
> >                coverageFileName.length() - executableExtension.size(),
> >                executableExtension.size(),
> >                coverageExtension
> >     -        );
> >     +        ); */
> >
> >
> >
> > If you are replacing this call, then just delete it -- don't comment it
> out.
> >
>
> I suggest the replace be changed to move past the '.' in the file name.
>
> I suspect the code here is still fragile because the extensions need to be
> the
> same size.
>
can't this be done by adding '.' in the append as in the v2 of this patch
to keep the extension size same  ?
are you suggesting to use replace instead ?

>
> Chris
>
> >
> >              if (!FileIsReadable( coverageFileName.c_str() )) {
> >                std::cerr << "warning: Unable to read coverage file: " <<
> >     coverageFileName
> >     --
> >     2.14.3
> >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20180513/f71d80d6/attachment-0002.html>