Move *_Control types of API objects to separate header file

Chris Johns chrisj at rtems.org
Thu Nov 8 06:42:42 UTC 2018


On 08/11/2018 17:22, Sebastian Huber wrote:
> On 08/11/2018 05:36, Chris Johns wrote:
>> On 08/11/2018 00:14, Sebastian Huber wrote:
>>> the <rtems.h> header file still exposes a lot of implementation details via the
>>> definition of the *_Control structures of the API objects. They are only
>>> necessary for the application configuration. I would like to move them to
>>> separate header files. Currently we have:
>>>
>>> <rtems/rtems/XYZ.h>
>>> <rtems/rtems/XYZimpl.h>
>>>
>>> I need a new name for this header file. For example:
>>>
>>> <rtems/rtems/XYZdata.h>
>>>
>>> An example patch is attached. Comments?
>>>
>>>   cpukit/include/rtems/confdefs.h          |   1 +
>>>   cpukit/include/rtems/rtems/ratemon.h     | 111 +---------------------------
>>>   cpukit/include/rtems/rtems/ratemondata.h | 123 +++++++++++++++++++++++++++++++
>> This is the ratemon "control struct" so does `ratemonctrl.h` work?
> 
> It contains also Rate_monotonic_Statistics, but most of the time it is just
> XYZ_Control.
> 
>>
>> Which ever way you go please make sure it will work for all the cases you wish
>> to change, for example these do not work `foodatadata.h`, or `fooctrlctrl.h`.
> 
> It would be:
> 
> rtems/posix/mqueuectrl.h
> rtems/posix/psignalctrl.h
> rtems/posix/semaphorectrl.h
> rtems/posix/shmctrl.h
> rtems/posix/timerctrl.h
> rtems/rtems/asrctrl.h
> rtems/rtems/attrctrl.h
> rtems/rtems/barrierctrl.h
> rtems/rtems/dpmemctrl.h
> rtems/rtems/eventctrl.h
> rtems/rtems/messagectrl.h
> rtems/rtems/modesctrl.h
> rtems/rtems/optionsctrl.h
> rtems/rtems/partctrl.h
> rtems/rtems/ratemonctrl.h
> rtems/rtems/regionctrl.h
> rtems/rtems/semctrl.h
> rtems/rtems/signalctrl.h
> rtems/rtems/statusctrl.h
> rtems/rtems/tasksctrl.h
> rtems/rtems/timerctrl.h
> 

Thanks for the list. Both work. I will let you decide :)

Chris

Chris


More information about the devel mailing list