[PATCH 2/3] score: Simplify _Objects_Initialize_information()

Chris Johns chrisj at rtems.org
Wed Nov 7 00:11:21 UTC 2018


On 06/11/2018 23:37, Sebastian Huber wrote:
> There is no need to make the minimum identifier dependent on the maximum
> per allocation.
> ---
>  cpukit/score/src/objectinitializeinformation.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/cpukit/score/src/objectinitializeinformation.c b/cpukit/score/src/objectinitializeinformation.c
> index 23c7819bfa..9905349213 100644
> --- a/cpukit/score/src/objectinitializeinformation.c
> +++ b/cpukit/score/src/objectinitializeinformation.c
> @@ -39,7 +39,6 @@ void _Objects_Do_initialize_information(
>  )
>  {
>    static Objects_Control *null_local_table = NULL;
> -  uint32_t                minimum_index;
>    Objects_Maximum         maximum_per_allocation;
>  
>    information->the_api            = the_api;
> @@ -88,9 +87,8 @@ void _Objects_Do_initialize_information(
>    /*
>     *  Calculate minimum and maximum Id's
>     */
> -  minimum_index = (maximum_per_allocation == 0) ? 0 : 1;

I am not sure you can remove this line. Something does not feel right, it was
long ago I wrote the original change and I seem to remember I thought the same
things and added this code after lots of testing. It may be this is not needed
with the way the code initialises managers now, I am not sure. What if someone
pulls in a manager but does not configure any resources?

Chris



More information about the devel mailing list