[PATCH v2] m68k/mcf52235: Add missing Copyright/License notices

Sebastian Huber sebastian.huber at embedded-brains.de
Fri Nov 9 07:39:28 UTC 2018


Hello Marçal,

I think each contributor needs its own line with a "Copyright (c) <first 
year>, <last year> <contributor>" structure. The <first year>, <last 
year> pattern is debatable:

https://gcc.gnu.org/ml/gcc/2012-06/msg00427.html

I trust that IBM is doing it right.

On 08/11/2018 19:16, Marçal wrote:
> Hi. I put the date as 2018 because I thought that the date had to be 
> the one when the file was last modified, and since it was last 
> modified (by me for this patch) in 2018, I put 2018. However, if this 
> is not correct, please tell me what type of years I have to put (I can 
> easily see when commits were done with git log) and I will make 
> another patch with the correct dates.
>
> On Thu, Nov 8, 2018 at 7:31 AM Sebastian Huber 
> <sebastian.huber at embedded-brains.de 
> <mailto:sebastian.huber at embedded-brains.de>> wrote:
>
>     On 07/11/2018 19:22, Joel Sherrill wrote:
>     > From: Sal<mcomajoancara at gmail.com <mailto:mcomajoancara at gmail.com>>
>     >
>     > This work was part of GCI 2018.
>     >
>     > Closes #2541.
>     > ---
>     >   bsps/m68k/mcf52235/btimer/btimer.c   | 11 +++++++----
>     >   bsps/m68k/mcf52235/clock/clock.c     | 13 +++++++++++++
>     >   bsps/m68k/mcf52235/console/console.c | 26
>     +++++++++++++++++++++-----
>     >   bsps/m68k/mcf52235/console/debugio.c | 19 ++++++++++++++-----
>     >   bsps/m68k/mcf52235/include/bsp.h     | 14 +++++++++++++-
>     >   bsps/m68k/mcf52235/include/tm27.h    | 10 +++++++++-
>     >   bsps/m68k/mcf52235/start/init52235.c | 12 ++++++++++++
>     >   bsps/m68k/mcf52235/start/linkcmds    | 11 ++++++++---
>     >   bsps/m68k/mcf52235/start/start.S     |  9 +++++++--
>     >   9 files changed, 104 insertions(+), 21 deletions(-)
>     >
>     > diff --git a/bsps/m68k/mcf52235/btimer/btimer.c
>     b/bsps/m68k/mcf52235/btimer/btimer.c
>     > index f912254..5987481 100644
>     > --- a/bsps/m68k/mcf52235/btimer/btimer.c
>     > +++ b/bsps/m68k/mcf52235/btimer/btimer.c
>     > @@ -2,10 +2,13 @@
>     >    *  Timer Init
>     >    *
>     >    *  Use the last DMA timer (DTIM3) as the diagnostic timer.
>     > - *
>     > - *  Author: W. Eric Norum<norume at aps.anl.gov
>     <mailto:norume at aps.anl.gov>>
>     > - *
>     > - *  COPYRIGHT (c) 2005.
>     > + */
>     > +
>     > +/*
>     > + *  COPYRIGHT (c) 2018
>
>     Is the Copyright date correct?
>
>     -- 
>     Sebastian Huber, embedded brains GmbH
>
>     Address : Dornierstr. 4, D-82178 Puchheim, Germany
>     Phone   : +49 89 189 47 41-16
>     Fax     : +49 89 189 47 41-09
>     E-Mail  : sebastian.huber at embedded-brains.de
>     <mailto:sebastian.huber at embedded-brains.de>
>     PGP     : Public key available on request.
>
>     Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.




More information about the devel mailing list