[PATCH v2] m68k/mcf52235: Add missing Copyright/License notices

Sebastian Huber sebastian.huber at embedded-brains.de
Tue Nov 13 06:30:39 UTC 2018



On 12/11/2018 17:30, Marçal wrote:
> diff --git a/bsps/m68k/mcf52235/btimer/btimer.c b/bsps/m68k/mcf52235/btimer/btimer.c
> index f9122542c2..2f0d54b00b 100644
> --- a/bsps/m68k/mcf52235/btimer/btimer.c
> +++ b/bsps/m68k/mcf52235/btimer/btimer.c
> @@ -2,10 +2,13 @@
>    *  Timer Init
>    *
>    *  Use the last DMA timer (DTIM3) as the diagnostic timer.
> - *
> - *  Author: W. Eric Norum<norume at aps.anl.gov>
> - *
> - *  COPYRIGHT (c) 2005.
> + */
> +
> +/*
> + *  COPYRIGHT (c) 2005, 2018

"Copyright (c)" is commonly used, e.g. just look at the FreeBSD and 
Linux sources.

> + *  Eric Norum<WENorum at lbl.gov>

The last contribution from Eric was in 2005.

Each author should have its own "Copyright (c) <first data>, <last date> 
<author>" line.

> + *  Matthew Riek<matthew.riek at ibiscomputer.com.au>

For example  Matthew Riek contributed only in 2008.

> + *  Ralf Corsepius<ralf.corsepius at rtems.org>
>    *  On-Line Applications Research Corporation (OAR).

If you look at the changes, then it is questionable that these two are 
copyright holders of contents in this file. I see only some cosmetic 
interface changes. What is the rule for adding a copyright statement?

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.




More information about the devel mailing list