[PATCH v2] rtemstoolkit: Add unit testing for the python modules

[Vijay Kumar Banerjee]

On Tue, 27 Nov 2018 at 10:28, Chris Johns <chrisj at rtems.org> wrote:

> On 27/11/2018 04:28, Vijay Kumar Banerjee wrote:
> > On Mon, 26 Nov 2018 at 16:27, Chris Johns <chrisj at rtems.org
> > <mailto:chrisj at rtems.org>> wrote:
> >     > On 26 Nov 2018, at 6:57 pm, Vijay Kumar Banerjee <
> vijaykumar9597 at gmail.com
> >     <mailto:vijaykumar9597 at gmail.com>> wrote:
> >     >
> >     >> On Mon, Nov 26, 2018 at 06:28:33PM +1100, Chris Johns wrote:
> >     >>
> >     >>> On 26 Nov 2018, at 5:21 pm, Vijay Kumar Banerjee
> >     <vijaykumar9597 at gmail.com <mailto:vijaykumar9597 at gmail.com>> wrote:
> >     >>> I'm getting the result Invalid while running hello.exe with
> rtems-test
> >     on leon3 (without coverage option)
> >     >>> attaching the log.
> >     >>
> >     >> Can you please revert or not apply patch 1 and let me know what
> happens?
> >     I have a feeling the coverage Qemu may be the old or different
> settings.
> >     > it works after reverting the first patch.
> >
> >     Can you define ‘qemu_use_serial_console’ when coverage is enabled?
> Doing
> >     this will work with the coverage qemu.
> >
> > ..... how to do that ?
> >
>
> I would:
>
> 1. Define 'coverage' in tester/rt/coverage.py in 'macros_'. See macrocs.py
> for
> the call
> https://git.rtems.org/rtems-tools/tree/rtemstoolkit/macros.py#n442.
>
> 2. In
> https://git.rtems.org/rtems-tools/tree/tester/rtems/testing/qemu.cfg#n61
> move this logic up to line 51 and use something like:
>
>  #
>  # Coverage, some builds of qemu support coverage.
>  #
>  %ifdef coverage
>   %define qemu_use_serial_console
>   %ifn %{defined bsp_qemu_cov_opts}
>    %define bsp_qemu_cov_opts %{nil}
>   %endif
>  %endif
>
> Thank you for explaining in such detail. It's working after this change.
I have attached the patch in this email.

> Chris
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20181127/a6b30737/attachment-0002.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-tester-Add-support-to-use-QEMU-serial-console-when-c.patch
Type: text/x-patch
Size: 1520 bytes
Desc: not available
URL: <http://lists.rtems.org/pipermail/devel/attachments/20181127/a6b30737/attachment-0002.bin>