[PATCH] rtemstoolkit: Fix imports and fix all unittests.

Chris Johns chrisj at rtems.org
Fri Oct 5 05:49:56 UTC 2018


On 05/10/2018 15:19, Sebastian Huber wrote:
> Hello Chris,
> 
> On 05/10/2018 06:24, chrisj at rtems.org wrote:
>> -#
>> -# Support to handle use in a package and as a unit test.
>> -# If there is a better way to let us know.
>> -#
>> -try:
>> -    from . import error
>> -    from . import execute
>> -    from . import log
>> -    from . import options
>> -    from . import path
>> -    from . import version
>> -except (ValueError, SystemError):
>> -    import error
>> -    import execute
>> -    import log
>> -    import options
>> -    import path
>> -    import version
>> +from rtemstoolkit import error
>> +from rtemstoolkit import execute
>> +from rtemstoolkit import log
>> +from rtemstoolkit import options
>> +from rtemstoolkit import path
>> +from rtemstoolkit import version
> 
> does this work on msys2?
> 

With python3? I have not tested python3.

It seems too with python2 on MSYS2. I ran a number of the unittests using the
command in the patch for each module in the rtemstoolkit and I have run a few
commands to show help etc. This means the module loading is working.

The try/except hack was there to lets the unit tests run. Using the `-m` option
to python is a much better way to handle testing.

There are some changes in the patch adding new features or improving something.

I have just noticed ...

chris at weng MINGW64 ~
$ /d/opt/rtems/xxx/bin/rtems-test
RTEMS Testing - Tester, undefined.not_released

The release handling is broken on MSYS2. I will need to take a look at this.

Chris



More information about the devel mailing list