[PATCH v3 1/8] Pinmux : Import from FreeBSD

Vijay Kumar Banerjee vijaykumar9597 at gmail.com
Sun Aug 11 19:22:08 UTC 2019


On Sun, Aug 11, 2019 at 8:40 PM Christian Mauderer <list at c-mauderer.de>
wrote:

> On 04/08/2019 18:41, Christian Mauderer wrote:
> > Hello Vijay,
> >
> > for the whole patch set:
> >
> > The order and groups are good now. I didn't find anything where I would
> > have big problems. All patches are compilable and libbsd still compiles
> > on a PowerPC target. The result is great (with some demo application I
> > get an image on the screen). So I'm OK with this version of the patch
> set.
> >
> > I'm still not entirely happy with the pinmux because it re-initializes
> > some pins that are already initialized by the BSP. But if no one has a
> > better idea that can be done in a reasonable time I would accept it like
> > it is. I think I would prefer it without the hack that needs an extra
> > overlay. If the patch set is committed in this form, we will need a
> > ticket for that (wait with creating it till the commit) so that a future
> > project can work on that ticket.
> >
> > Best regards
> >
> > Christian
>
> Hello Vijay,
>
> I pushed the patch set just now and created a ticket for the pinmux:
>
> https://devel.rtems.org/ticket/3782#ticket

Hi!

It's great to see all of it merged. Thanks for all the help and guidance.
It was an amazing experience working on this project and learning so
much from you.

Thank you,
Vijay

>


>
Best regards
>
> Christian
>
> >
> > On 03/08/2019 22:19, Vijay Kumar Banerjee wrote:
> >> ---
> >>  .../sys/arm/ti/am335x/am335x_scm_padconf.c    | 305 ++++++++++++
> >>  .../sys/arm/ti/am335x/am335x_scm_padconf.h    |  47 ++
> >>  freebsd/sys/arm/ti/omap4/omap4_scm_padconf.h  |  83 ++++
> >>  freebsd/sys/arm/ti/ti_pinmux.c                | 463 ++++++++++++++++++
> >>  freebsd/sys/arm/ti/ti_pinmux.h                |  80 +++
> >>  freebsd/sys/dev/fdt/fdt_pinctrl.c             | 160 ++++++
> >>  6 files changed, 1138 insertions(+)
> >>  create mode 100644 freebsd/sys/arm/ti/am335x/am335x_scm_padconf.c
> >>  create mode 100644 freebsd/sys/arm/ti/am335x/am335x_scm_padconf.h
> >>  create mode 100644 freebsd/sys/arm/ti/omap4/omap4_scm_padconf.h
> >>  create mode 100644 freebsd/sys/arm/ti/ti_pinmux.c
> >>  create mode 100644 freebsd/sys/arm/ti/ti_pinmux.h
> >>  create mode 100644 freebsd/sys/dev/fdt/fdt_pinctrl.c
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20190812/ed472dfb/attachment-0002.html>


More information about the devel mailing list