[PATCH 6/7] bsps: Remove uses of BSP_GET_WORK_AREA_DEBUG

Sebastian Huber sebastian.huber at embedded-brains.de
Tue Dec 17 05:57:18 UTC 2019


On 17/12/2019 00:34, Chris Johns wrote:
> 
>> On 16 Dec 2019, at 11:42 pm, Sebastian Huber <Sebastian.Huber at embedded-brains.de> wrote:
>>
>> The code covered by BSP_GET_WORK_AREA_DEBUG was basically dead code
>> since there was no normal way to activate it (e.g. via a BSP
>> configuration option).  BSP developers should use a debugger instead.
> 
> You will need to establish a base level requirement of a debugger across the whole project before this statement makes sense and doing that does not make sense to me.

It is just a recommendation.  My experience tells me that doing a BSP 
development without a debugger is a waste of time.

> 
>> If this output via printk() turns out to be still wanted by users, it
>> can be added as an application configuration option, e.g.
>> CONFIGURE_ENABLE_VERBOSE_MEMORY_INITIALIZATION.
> 
> Why not use that config define that other part you want to removed?

Sorry, I don't understand this sentence. Do you mean that I should add 
this CONFIGURE_ENABLE_VERBOSE_MEMORY_INITIALIZATION configuration 
option? Maybe a CONFIGURE_ENABLE_VERBOSE_INITIALIZATION makes more 
sense. We can print some information for each step.

> 
> Also  please consider at this time of year I am really busy and patches need to sit longer before being considered as OK. :)

Ok, I would like to get the two change sets integrated before we create 
the RTEMS 5 branch. This would make back ports easier.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.


More information about the devel mailing list