[PATCH 11/11] libdl: Add powerpc large memory and small data support.

[Sebastian Huber]

On 05/02/2019 02:43, chrisj at rtems.org wrote:
> +	/*
> +	 * Set bsp_section_sdata_bss_maximum_size to 1 to use the maximum, eg:
> +	 *
> +	 *  bsp_section_sdata_bss_maximum_size = 1;
> +	 */
> +	bsp_section_sdata_bss_default_size =
> +		DEFINED(bsp_section_sdata_bss_maximum_size) ? 65536 : 0;
> +	/*
> +	 * Set bsp_section_sdata_bss_size to the system's sdata and bss data size, eg:
> +	 *
> +	 *  bsp_section_sdata_bss_maximum_size = 4096;
> +	 */
> +	bsp_section_sdata_sbss_size = DEFINED(bsp_section_sdata_bss_size) ?
> +		bsp_section_sdata_bss_size : bsp_section_sdata_bss_default_size;

I would not make it more complicated than necessary. The systems using 
libdl probably all have network support and file systems. For them 
wasting 64KiB shouldn't be an issue. I would rename the 
bsp_section_sdata_bss_maximum_size to something like 
bsp_section_use_maximum_sdata_size since it is actually not a size.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.