[PATCH 5/5] Add bsp riscv/grlib

Sebastian Huber sebastian.huber at embedded-brains.de
Thu Jan 17 07:04:00 UTC 2019


Hello Jiri,

it would be nice if we could use the new license for this new BSP:

https://git.rtems.org/rtems/tree/LICENSE.BSD-2-Clause

BSP names should be unique even across architectures. So, I think the 
name grlib is a bit too unspecific. What about griscv?

On 16/01/2019 15:44, Jiri Gaisler wrote:
>   bsps/riscv/grlib/clock/clockdrv.c             | 203 +++++++++
>   bsps/riscv/grlib/config/grlib.cfg             |   9 +
>   bsps/riscv/grlib/console/console.c            | 162 ++++++++
>   bsps/riscv/grlib/console/printk_support.c     | 126 ++++++
>   bsps/riscv/grlib/headers.am                   |  16 +
>   bsps/riscv/grlib/include/amba.h               | 143 +++++++
>   bsps/riscv/grlib/include/bsp.h                |  68 ++++
>   bsps/riscv/grlib/include/bsp/irq.h            |  73 ++++
>   bsps/riscv/grlib/include/bsp/riscv.h          |  57 +++

Do you need this riscv.h?

>   bsps/riscv/grlib/include/dev/serial/htif.h    |  54 +++

Do you need this htif.h?

>   bsps/riscv/grlib/include/tm27.h               |   1 +
>   bsps/riscv/grlib/irq/irq.c                    | 145 +++++++
>   bsps/riscv/grlib/start/amba.c                 | 115 ++++++
>   bsps/riscv/grlib/start/bsp_fatal_halt.c       |  34 ++
>   bsps/riscv/grlib/start/bsp_specs              |   9 +
>   bsps/riscv/grlib/start/bspsmp.c               |  98 +++++
>   bsps/riscv/grlib/start/bspstart.c             |  71 ++++
>   bsps/riscv/grlib/start/linkcmds.base          | 385 ++++++++++++++++++

The linkcmds.base should be definitely shared with the generic existing 
BSP family and move to bsps/riscv/shared/start/linkcmds.base.

>   bsps/riscv/grlib/start/linkcmds.in            |  46 +++
>   bsps/riscv/grlib/start/start.S                | 142 +++++++

The start.S should be shared with the existing BSP family and move to 
bsps/riscv/shared/start/start.S.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.



More information about the devel mailing list