[PATCH v3 7/8] grlib: make memory coherency cpu-independent

Sebastian Huber sebastian.huber at embedded-brains.de
Mon Jan 21 12:11:14 UTC 2019


On 21/01/2019 12:56, Jiri Gaisler wrote:
> On 1/21/19 11:33 AM, Sebastian Huber wrote:
>> On 21/01/2019 11:30, Jiri Gaisler wrote:
>>> diff --git a/bsps/shared/grlib/spw/grspw.c
>>> b/bsps/shared/grlib/spw/grspw.c
>>> index fbaadd1e13..7d99831e71 100644
>>> --- a/bsps/shared/grlib/spw/grspw.c
>>> +++ b/bsps/shared/grlib/spw/grspw.c
>>> @@ -25,8 +25,8 @@
>>>      #include <grlib/grlib_impl.h>
>>>    -#ifndef CPU_SPARC_HAS_SNOOPING
>>> -#define CPU_SPARC_HAS_SNOOPING 1
>>> +#ifndef GRLIB_DMA_IS_CACHE_COHERENT
>>> +#define GRLIB_DMA_IS_CACHE_COHERENT 1
>>>    #endif
>>>    
>> I would remove this block. Things should be only defined in one place.
> True, How about this?
>
>

Looks good, can you check it in?

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.



More information about the devel mailing list