[PATCH v3 7/8] grlib: make memory coherency cpu-independent

Jiri Gaisler jiri at gaisler.se
Mon Jan 21 11:56:27 UTC 2019


On 1/21/19 11:33 AM, Sebastian Huber wrote:
> On 21/01/2019 11:30, Jiri Gaisler wrote:
>> diff --git a/bsps/shared/grlib/spw/grspw.c
>> b/bsps/shared/grlib/spw/grspw.c
>> index fbaadd1e13..7d99831e71 100644
>> --- a/bsps/shared/grlib/spw/grspw.c
>> +++ b/bsps/shared/grlib/spw/grspw.c
>> @@ -25,8 +25,8 @@
>>     #include <grlib/grlib_impl.h>
>>   -#ifndef CPU_SPARC_HAS_SNOOPING
>> -#define CPU_SPARC_HAS_SNOOPING 1
>> +#ifndef GRLIB_DMA_IS_CACHE_COHERENT
>> +#define GRLIB_DMA_IS_CACHE_COHERENT 1
>>   #endif
>>   
>
> I would remove this block. Things should be only defined in one place.


True, How about this?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: grlib_coherency2.patch
Type: text/x-patch
Size: 1426 bytes
Desc: not available
URL: <http://lists.rtems.org/pipermail/devel/attachments/20190121/5023945f/attachment-0002.bin>


More information about the devel mailing list