[PATCH v4] Add mmap

[Sebastian Huber]

On 17/07/2019 22:28, Vijay Kumar Banerjee wrote:
> +static int
> +testmmap(struct cdev *dev, vm_ooffset_t offset, vm_paddr_t *paddr,
> +         int nprot, vm_memattr_t *memattr)
> +{
> +	test_state *state = dev->si_drv1;
> +
> +	assert(memattr == VM_MEMATTR_DEFAULT);
> +	assert(paddr != NULL);
> +	assert(nprot != PROT_NONE);

If you know the value in your test, then test for this value. You should 
avoid != tests whenever possible.

Here the nprot should be PROT_READ | PROT_WRITE?

Does the MAP_SHARED not end up here somehow?

> +	assert(*state == TEST_KQFILTER);
> +	*state = TEST_MMAP;
> +
> +	return 0;
> +}
> +

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.