[PATCH] arm/start.S: Do not use a scratch register to hold the stack pointer

Sebastian Huber sebastian.huber at embedded-brains.de
Fri Jul 26 05:45:11 UTC 2019


On 26/07/2019 07:41, Chris Johns wrote:
> On 26/7/19 3:07 pm, Sebastian Huber wrote:
>> On 26/07/2019 07:06, Sebastian Huber wrote:
>>> Hello Chris,
>>>
>>> I am not sure, if using r8 is the right thing to do since r8..r14 are banked
>>> in FIQ mode. I think the bsp_start_arm_drop_hyp_mode needs to be changed to
>>> not touch r3, it can use r1 instead.
>> I think the code should move to start.S also.
> Sure, if you would like to do that. I have no time to spend on that sort of
> change. I am happy to test a change.
> 
> In the meantime the solution on the table is the best one we have. I will push
> it tomorrow if nothing better is posted.

I write a patch.  Using r8 is not the right fix since this breaks the 
FIQ stack initialization.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.



More information about the devel mailing list