[PATCH] Add framebuffer in BBB

[Vijay Kumar Banerjee]

On Fri, Jul 26, 2019 at 5:11 PM Christian Mauderer <
christian.mauderer at embedded-brains.de> wrote:

> On 26/07/2019 13:22, Vijay Kumar Banerjee wrote:
> > Hello everyone!
> >
> > I'm excited to post the following patchset. With this patchset
> > I have the framebuffer working in BBB and have tested it with a
> > BBB revC with HDMI connected Screen.
> >
> > This patchset uses mmap and hence it's necessary to apply the
> > patche ON TOP OF mmap patch to avoid merge conflict.
> >
> > In reply to this mail, I'll be attaching a picture of the screen
> > where my rectangle drawing application made a nice red rectangle
> > on the screen just like in FreeBSD.
> >
> > Thanks and regards,
> > Vijay
> >
>
> Hello Vijay,
>
> it's great that you now have a working driver. Well done.
>
> I hadn't had a look at most patches yet and most likely that will need a
> bit of time. It's a lot of stuff. Most likely the bigger patches won't
> reach the mailing list so maybe adding a link to a branch on your github
> repo would be good.
>
> I'll reorder them and push to remote today and add it in this thread.

> Note: Please don't send a v2 right now. I'm sure there are more comments
> (maybe not only from me). Collect comments for at least one or two days
> and create an update afterwards.
>
> Some notes reading the patch overview:
>
> > [PATCH 01/10] TDA19988 : Import from FreeBSD
> > [PATCH 02/10] TDA19988 : port to RTEMS
> > [PATCH 03/10] am335x display drivers: Import from FreeBSD
> > [PATCH 04/10] am335x display drivers : Port to RTEMS
> > [PATCH 05/10] fbd : Import from FreeBSD
> > [PATCH 06/10] fbd : Port to RTEMS
>
> Is fbd a prerequisite of am335x_lcd? In that case it would have been
> better to reorder the patches. As long as every version compiles (to
> allow git bisect) I would accept that order too. But as a general rule
> prerequisites should be prior to the parts that use it.
>
> am335x_lcd is the prerequisite for fbd.

> > [PATCH 07/10] VT : Import from FreeBSD
> > [PATCH 08/10] VT : Port to RTEMS
>
> Is the vt still necessary? I think it was an intermediate step to try
> whether it's initializing the display. Did you try without it?
>
> I tried without it, it's giving some noise in the screen and the the open
call to framebuffer is returning error without vt. I guess the vt
initialization
is necessary.

> > [PATCH 09/10] TI Pinmux : Import from FreeBSD
> > [PATCH 10/10] TI Pinmux : Port to RTEMS
>
> Again: prerequisite. So they should be one of the first.
>
> OK. I'll put it in the first.

> Best regards
>
> Christian
> --
> --------------------------------------------
> embedded brains GmbH
> Herr Christian Mauderer
> Dornierstr. 4
> D-82178 Puchheim
> Germany
> email: christian.mauderer at embedded-brains.de
> Phone: +49-89-18 94 741 - 18
> Fax:   +49-89-18 94 741 - 08
> PGP: Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20190726/7c84b8e9/attachment-0002.html>