Instructions to send a Patch

[Vaibhav Gupta]

On Thu, 30 May, 2019, 2:48 PM Aditya Upadhyay, <aadit0402 at gmail.com> wrote:

> On Thu, May 30, 2019 at 12:52 AM Gedare Bloom <gedare at rtems.org> wrote:
> >
> > On Tue, May 28, 2019 at 8:23 PM Vaibhav Gupta <vaibhavgupta40 at gmail.com>
> wrote:
> > >
> > >
> > >
> > > On Tue, May 28, 2019 at 11:47 AM Aditya Upadhyay <aadit0402 at gmail.com>
> wrote:
> > >>
> > >> On Mon, May 27, 2019 at 10:42 PM Vaibhav Gupta <
> vaibhavgupta40 at gmail.com> wrote:
> > >> >
> > >> > Hello, okay I will keep that in mind.
> > >> > .
> > >> > .
> > >> > .
> > >> > .
> > >> > But there is one problem with this patch then.
> > >> > .
> > >> > .
> > >> > If i just copy-paste ndbm.h, db.h(needed by ndbm.h) and ndbm.c and
> make the entry of ndbm.c  in Makefile.am.
> > >> > Then run 'autoreconf' to add the entry for ndbm.c in Makefile.in.
> And then run `make` command. There will be compilation error.
> > >> > .
> > >>
> > >> See Instructions here about regenerating the configuration files in
> newlib.
> > >> https://sourceware.org/newlib/README
> > >> Newlib uses a specific version of autoconf. You can use `autoreconf
> > >> -fvi` command to regenerate that
> > >> Makefile.in file.
> > >
> > > Okay
> > >>
> > >>
> > >> > Header files needed by libc/posic/*.c files are present in
> libc/include directory. It is default path.
> > >> > .
> > >> > But ndbm.c also requires "hash.h" which is present inside
> "libc/search".
> > >> > .
> > >> > To over come it, i had to modify the entry of ndbm.c in Makefile.in
> and add "-I (topr_srcdir)/search" to specify the compiler for alternative
> source path.
> > >>
> > >> If you specify any header file inclusion in Makefile.am, then you will
> > >> need to add the things manually
> > >> and when you will run autoreconf command, this .in file will get
> updated.
> > >>
> > > I guess I will need to modify configure.in file. If I am not wrong
> that is responsible for what autoreconf is doing.
> >
> > You shouldn't be manually modifying any *.in files.
>
> Basically, After adding any files, We just need to make some entries
> in these two files: configure.ac and Makefile.am files.
> autoheader, autoconf and automake are the tools used when you execute
> autoreconf command. It generate config.h.in, Makefile. in and that
> configure script and When you execute configure script, you get
> config.h and Makefile.
> Take a look at page no 26 of this file.
> https://elinux.org/images/4/43/Petazzoni.pdf

I am still not able to find where exactly in Makefile.am and configure.ac ,
i have to mention for "search/hash.h".

The approach i used was, if posix files are compiled using headers in
"include" folder, it must be mentioned about it somewhere inside
Makefile.am or configure.in. I thought i will mention for "search/hash.h"
at the same place.

>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20190601/bc3ed5b6/attachment.html>