[PATCH] Write event stream in file

[Sebastian Huber]

On 25/06/2019 10:49, Ravindra Kumar Meena wrote:
>      >     [242/254] Compiling misc/record/record-main.c
>      >     ../misc/record/record-main.c: In function ‘print_item’:
>      >     ../misc/record/record-main.c:152:14: warning: variable
>     ‘seconds’ set
>      >     but
>      >     not used [-Wunused-but-set-variable]
>      >            uint32_t seconds;
>      >                     ^~~~~~~
>      >     ../misc/record/record-main.c: In function ‘handler’:
>      >     ../misc/record/record-main.c:161:14: warning: ‘ns’ may be used
>      >     uninitialized in this function [-Wmaybe-uninitialized]
>      >          ctf_item.ns=ns;
>      >          ~~~~~~~~~~~^~~
>      >     ../misc/record/record-main.c:149:12: note: ‘ns’ was declared here
>      >          uint32_t ns;
>      >                   ^~
>      >
>      > Okay. I also got these warnings after reconfiguring again. This
>     can be
>      > resolved if we remove the if block. I think there is no need for
>     it now.
> 
>     No, sorry, please fix these warnings immediately. Warnings about
>     uninitialized variables are very likely a hard error.
> 
> Okay. I have resolved the issue.
> https://github.com/rmeena840/rtems-tools/commit/23aeaa0251e89822ac24108f3d0c34af36b610fb
> 
> Have a look.

Why do you still have the "ns" variable and this if block? Why can't you 
simply do this:

ctf_item.ns = item->ns;

?

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.