[PATCH 4/6] am335x display drivers: Port to RTEMS

[Christian Mauderer]

On 30/06/2019 18:26, Vijay Kumar Banerjee wrote:
>     > @@ -799,6 +799,14 @@ class display(builder.Module):
>     >                  'sys/dev/videomode/ediddevs.h',
>     >                  'sys/dev/videomode/ediddevs_data.h',
>     >                  'sys/dev/videomode/vesagtf.h',
>     > +                'sys/arm/ti/am335x/am335x_lcd.h',
>     > +                'sys/arm/ti/am335x/am335x_pwm.h',
>     > +                'sys/dev/fb/fbreg.h',
>     > +                'sys/dev/vt/vt.h',
>     > +                'sys/teken/teken.h',
>     From the header:
> 
>        This library converts an UTF-8 stream of bytes to terminal drawing
>        commands.
> 
>     Where is that necessary?
> 
> This is being included in the terminal.h, the defines are necessary hence
> I haven't added teken.c 
> 

OK. I could continue to ask where terminal.h was necessary but as long
as it's headers I don't have a big problem with it. Just be careful that
the drivers don't assume that they can use a subsystem that isn't there.
Sometimes with such dependencies you get code that compiles and runs but
just doesn't really do anything because it waits to be called by some
other sub system.