[PATCH] shell: Correct argument order of `mfill`
Sebastian Huber
sebastian.huber at embedded-brains.de
Fri Mar 8 06:40:54 UTC 2019
On 01/03/2019 19:21, Jonathan Brandmeyer wrote:
> ---
> cpukit/libmisc/shell/main_mfill.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cpukit/libmisc/shell/main_mfill.c b/cpukit/libmisc/shell/main_mfill.c
> index d8e2fcf74c..47a55d3a2f 100644
> --- a/cpukit/libmisc/shell/main_mfill.c
> +++ b/cpukit/libmisc/shell/main_mfill.c
> @@ -60,7 +60,7 @@ static int rtems_shell_main_mfill(
> /*
> * Now fill the memory.
> */
> - memset(addr, size, value);
> + memset(addr, value, size);
>
> return 0;
> }
Fixing this bug on the master is easy, but the bug is there in all RTEMS
versions since 2007. If you fix this properly means you need tickets for
a couple of RTEMS versions and an individual commit message
corresponding to each ticket. The administration overhead is huge. I
just fixed it for RTEMS 5.1:
https://devel.rtems.org/ticket/3720
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber at embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
More information about the devel
mailing list