[PATCH 0/3] Fixed ability to enable console polling for certain BSPs

Joel Sherrill joel at rtems.org
Tue Mar 26 15:17:43 UTC 2019


On Tue, Mar 26, 2019 at 9:36 AM Sebastian Huber <
sebastian.huber at embedded-brains.de> wrote:

> On 26/03/2019 14:56, Lou Woods wrote:
> > From: Lou Woods <Lou.Woods at OARCorp.com>
> >
> > I discovered that I was not able to turn off interrupt-based console
> mode on the
> > Xilinx Zynq BSP under Qemu via the configure command.  The fix simply
> exchanges
> > #ifdef XXX_CONSOLE_USE_INTERRUPTS for
> > #if XXX_CONSOLE_USE_INTERRUPTS for the BSP specific console code.
>
> You can disable it via the configure command line, just use
>
> XXX_CONSOLE_USE_INTERRUPTS=
>
> I have never seen setting it to nothing ever documented anywhere in
the RTEMS pantheon of material. All examples I have ever seen set
these to a value


> These feature defines are not uniformly used, some use #if other use
> #ifdef.
>

Changing these ifdef CONSOLE_USE to #if ensures they work if the value
is set to nothing or 0. I don't see how this isn't an improvement.

--joel


> --
> Sebastian Huber, embedded brains GmbH
>
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone   : +49 89 189 47 41-16
> Fax     : +49 89 189 47 41-09
> E-Mail  : sebastian.huber at embedded-brains.de
> PGP     : Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20190326/0ee77186/attachment-0002.html>


More information about the devel mailing list