[PATCH] Disable zynq_uart_set_attributes that prevents console input

Joel Sherrill joel at rtems.org
Wed Mar 27 18:38:24 UTC 2019


On Wed, Mar 27, 2019 at 1:07 AM Sebastian Huber <
sebastian.huber at embedded-brains.de> wrote:

> On 26/03/2019 15:17, Lou Woods wrote:
> > From: Lou Woods<Lou.Woods at OARCorp.com>
> >
> > This patch fully disables the zynq_uart_set_attributes handler that had
> > previously been commented out, but was returning false.  This prevented
> > fileio.exe from blocking on the rtems_shell_wait_for_input call.
>
> Would it make sense to move this comment to the commit message?
>

Yeah. It would.

This is certainly a case of starting with something broken and tracking it
through multiple changes using git blame to figure out why it wasn't
working.

>
> --
> Sebastian Huber, embedded brains GmbH
>
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone   : +49 89 189 47 41-16
> Fax     : +49 89 189 47 41-09
> E-Mail  : sebastian.huber at embedded-brains.de
> PGP     : Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20190327/c5f3632b/attachment-0002.html>


More information about the devel mailing list