[rtems-libbsd commit] Remove dangerous weak definition of getentropy()

[Chris Johns]

Hi,

The change makes sense from a security point of view but are you sure there are
no references to these symbols for those users who do not need this stuff to work?

On 13/5/19 7:20 pm, Sebastian Huber wrote:
> Module:    rtems-libbsd
> Branch:    master
> Commit:    ab80f78a20cae1f580d3474a43a0973b9ad2f1c5
> Changeset: http://git.rtems.org/rtems-libbsd/commit/?id=ab80f78a20cae1f580d3474a43a0973b9ad2f1c5
> 
> Author:    Sebastian Huber <sebastian.huber at embedded-brains.de>
> Date:      Mon May 13 10:33:19 2019 +0200
> 
> Remove dangerous weak definition of getentropy()
> 
> All BSP supporting libbsd should provide this function.

Would some documentation on what they need to do and at the risk of being flamed
by security specialists a sample implementation or link a user can use to see
what is needed be useful?

Thanks
Chris

> 
> ---
> 
>  rtemsbsd/rtems/rtems-kernel-init.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/rtemsbsd/rtems/rtems-kernel-init.c b/rtemsbsd/rtems/rtems-kernel-init.c
> index 4d9851e..ee34d03 100644
> --- a/rtemsbsd/rtems/rtems-kernel-init.c
> +++ b/rtemsbsd/rtems/rtems-kernel-init.c
> @@ -115,18 +115,6 @@ volatile uint32_t _Watchdog_Ticks_since_boot;
>  extern volatile int32_t _bsd_ticks
>      __attribute__ ((__alias__("_Watchdog_Ticks_since_boot")));
>  
> -__attribute__((__weak__)) void _arc4random_getentropy_fail(void)
> -{
> -
> -}
> -
> -__attribute__((__weak__)) int getentropy(void *buf, size_t n)
> -{
> -
> -	memset(buf, 0, n);
> -	return (0);
> -}
> -
>  rtems_status_code
>  rtems_bsd_initialize(void)
>  {
> 
> _______________________________________________
> vc mailing list
> vc at rtems.org
> http://lists.rtems.org/mailman/listinfo/vc
>