Instructions to send a Patch

Gedare Bloom gedare at rtems.org
Wed May 29 19:22:41 UTC 2019


On Tue, May 28, 2019 at 8:23 PM Vaibhav Gupta <vaibhavgupta40 at gmail.com> wrote:
>
>
>
> On Tue, May 28, 2019 at 11:47 AM Aditya Upadhyay <aadit0402 at gmail.com> wrote:
>>
>> On Mon, May 27, 2019 at 10:42 PM Vaibhav Gupta <vaibhavgupta40 at gmail.com> wrote:
>> >
>> > Hello, okay I will keep that in mind.
>> > .
>> > .
>> > .
>> > .
>> > But there is one problem with this patch then.
>> > .
>> > .
>> > If i just copy-paste ndbm.h, db.h(needed by ndbm.h) and ndbm.c and make the entry of ndbm.c  in Makefile.am.
>> > Then run 'autoreconf' to add the entry for ndbm.c in Makefile.in.  And then run `make` command. There will be compilation error.
>> > .
>>
>> See Instructions here about regenerating the configuration files in newlib.
>> https://sourceware.org/newlib/README
>> Newlib uses a specific version of autoconf. You can use `autoreconf
>> -fvi` command to regenerate that
>> Makefile.in file.
>
> Okay
>>
>>
>> > Header files needed by libc/posic/*.c files are present in libc/include directory. It is default path.
>> > .
>> > But ndbm.c also requires "hash.h" which is present inside "libc/search".
>> > .
>> > To over come it, i had to modify the entry of ndbm.c in Makefile.in and add "-I (topr_srcdir)/search" to specify the compiler for alternative source path.
>>
>> If you specify any header file inclusion in Makefile.am, then you will
>> need to add the things manually
>> and when you will run autoreconf command, this .in file will get updated.
>>
> I guess I will need to modify configure.in file. If I am not wrong that is responsible for what autoreconf is doing.

You shouldn't be manually modifying any *.in files.



More information about the devel mailing list