[PATCH] record: Add support for interrupt handlers
chrisj at rtems.org
Thu Sep 5 08:09:11 UTC 2019
On 5/9/19 5:53 pm, Sebastian Huber wrote:
> ----- Am 5. Sep 2019 um 7:29 schrieb Chris Johns chrisj at rtems.org:
>> On 5/9/19 2:42 pm, Sebastian Huber wrote:
>>> ----- Am 5. Sep 2019 um 0:28 schrieb Chris Johns chrisj at rtems.org:
>>>> On 4/9/19 9:46 pm, Sebastian Huber wrote:
>>>> Also it should be `std::fwrite`.
>>> Ok, it seems <stdio.h> was included via <iostream>. I will fix this.
>> I think we can take C++ development styles offline and chat personally, maybe in
>> person soon. :)
> How far do you want to go with this std:: stuff, e.g. what about std::size_t?
Just calls, classes, etc so it shows where something comes from? I did not know
std::size_t worked. For example with `fwrite` I had to check if this was locally
provided in a class. For C++ I use `std::cout` and for C I use `::memset`.
I have got in the habit of doing this as some options give warnings when missing.
Maybe we should just place a "using namespace std;" in *.cc files (this would
violate also a Google rule).
I agree please do not do this. It undermines the readability of the code.
More information about the devel