[PATCH] rtems: Make rtems_version_control_key() safer

Peter Dufault dufault at hda.com
Tue Sep 10 18:30:50 UTC 2019

> On Sep 9, 2019, at 22:00 , Chris Johns <chrisj at rtems.org> wrote:
> I would prefer we provide an interface to say the version control key has been
> set rather than exposing how we manage it. I think the change to not return NULL
> is the correct one. What about adding ..
> bool rtems_version_control_key_valid( void )
> {
>  return strlen( rtems_version_control_key( ) ) != 0;
> }
> I have a feeling we may wedge ourselves in the future with users having code to
> check the length.
> Chris

I usually want both, that is, I always want the consistent error code interface (0 vs !0) and I frequently want more convenient interfaces.

Peter Dufault
HD Associates, Inc.      Software and System Engineering

This email is delivered through the public internet using protocols subject to interception and tampering.

More information about the devel mailing list