[RTEMS][PATCH v2 0/2] riscv: add freedom E310 Arty A7

[Hesham Almatary]

On Wed, 11 Sep 2019 at 15:12, Hesham Almatary <heshamelmatary at gmail.com> wrote:
>
> On Wed, 11 Sep 2019 at 14:07, Pragnesh Patel <pragnesh.patel at sifive.com> wrote:
> >
> > Fredom E310 Arty has a support for FDT but right now, u-boot (or any
> > bootloader) will not copy FDT address into CPU register (a1 for RISCV)
> > instead we have given FDT address manually as shown below:
> >
> On FPGA/hardware, a bootrom (part of your Xilinx project) should be
> doing this (read: loading a1 with dtb address) already.
>
u-boot, pk, etc assume so and should follow the same convention of
passing the DTB address in a1 for the next stage bootloader/OS.

> > bsps/riscv/shared/start/start.S
> >
> >  #ifdef BSP_START_COPY_FDT_FROM_U_BOOT
> > +  LADDR   a1, frdme310arty_dtb
> >     mv      a0, a1
> >     call    bsp_fdt_copy
> >  #endif
> >
> > bsps/riscv/riscv/dts/frdme310arty_dtb_array.c
> >  unsigned char frdme310arty_dtb[] = {
> >    0xd0, 0x0d, 0xfe, 0xed, 0x00, 0x00, 0x0c, 0x00, 0x00, 0x00, 0x00, 0x38,
> >    0x00, 0x00, 0x0a, 0x74, 0x00, 0x00, 0x00, 0x28, 0x00, 0x00, 0x00, 0x11,
> > }
> >
> > Can you suggest me a better way of doing this?
> >
> > - Pragnesh
> >
> > On Wed, Sep 11, 2019 at 2:18 PM Sebastian Huber
> > <sebastian.huber at embedded-brains.de> wrote:
> > >
> > > On 11/09/2019 10:43, Pragnesh Patel wrote:
> > > > Ok understood.
> > > > If i will add Freedom E310 related code in bsp/riscv/riscv directory
> > > > then there are some code changes related to "console, btimer and other
> > > > minor things" so can i add this changes under new #define let's say
> > > > #define RISCV_ENABLE_FRDME310_SUPPORT ?
> > >
> > > Please don't add a new btimer driver. This is a legacy driver. For this
> > > BSP we can switch to the btimer-cpucounter.c variant.
> > >
> > > >
> > > > I am planning to add this #define in configure.ac through
> > > > RTEMS_BSPOPTS_SET([RISCV_ENABLE_FRDME310_SUPPORT],[*],[1]), By default
> > > > it is disabled.
> > > > what's your suggestion on this?
> > >
> > > Yes, this sounds good. If there are to many places with this define,
> > > then we have to think again how to proceed.
> > >
> > > --
> > > Sebastian Huber, embedded brains GmbH
> > >
> > > Address : Dornierstr. 4, D-82178 Puchheim, Germany
> > > Phone   : +49 89 189 47 41-16
> > > Fax     : +49 89 189 47 41-09
> > > E-Mail  : sebastian.huber at embedded-brains.de
> > > PGP     : Public key available on request.
> > >
> > > Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
>
>
> --
> Hesham



-- 
Hesham