[PATCH v3] Tests for inttype.h methods

[Joel Sherrill]

I tested it on the pc386 BSP. Once the style stuff is fixed, it should be
OK to push.

--joel

On Fri, Apr 3, 2020 at 1:07 PM Gedare Bloom <gedare at rtems.org> wrote:

> Couple of formatting problems to fix:
>
> On Fri, Apr 3, 2020 at 10:53 AM Eshan dhawan <eshandhawan51 at gmail.com>
> wrote:
> >
> > ---
> >  testsuites/psxtests/psxinttypes01/init.c      | 25 ++++++++++++++++---
> >  .../psxtests/psxinttypes01/psxinttypes01.doc  | 10 +++++++-
> >  2 files changed, 31 insertions(+), 4 deletions(-)
> >
> > diff --git a/testsuites/psxtests/psxinttypes01/init.c
> b/testsuites/psxtests/psxinttypes01/init.c
> > index 030aa2aa57..d86313b251 100644
> > --- a/testsuites/psxtests/psxinttypes01/init.c
> > +++ b/testsuites/psxtests/psxinttypes01/init.c
> > @@ -6,6 +6,7 @@
> >  /*
> >   * SPDX-License-Identifier: BSD-2-Clause
> >   *
> > + * Copyright (C) 2020, Eshan Dhawan
> >   * Copyright (C) 2019, Aditya Upadhyay and Vaibhav Gupta
> >   *
> >   * Redistribution and use in source and binary forms, with or without
> > @@ -64,11 +65,29 @@ rtems_task Init(rtems_task_argument ignored)
> >    wchar_t  *nptr2_n_errange = L"-9999999999999999999999";
> >    wchar_t  *endptr2         = NULL;
> >
> > -  intmax_t  result_strtoimax;
> > +  intmax_t  result_strtoimax, result_imaxabs, input_1, input_2 ;
> no spaces before semi-colon
>
> > +  imaxdiv_t result_exp, result_imaxdiv ;
> ditto
>
> >    uintmax_t result_strtoumax;
> >
> >    TEST_BEGIN();
> > -
> > +  /* Test for imaxabs */
> > +  input_1 = -10 ;
> > +  result_imaxabs = 10 ;
> ditto
>
> > +  rtems_test_assert( imaxabs(input_1) == result_imaxabs );
> > +
> > +  input_1 = 10 ;
> > +  result_imaxabs = 10 ;
> ditto
>
> > +  rtems_test_assert( imaxabs(input_1) == result_imaxabs );
> > +
> > +  /* Test for imaxdiv */
> > +  input_1 = 10 ;
> > +  input_2 = 3 ;
> > +  result_exp.quot = input_1 / input_2 ;
> > +  result_exp.rem =  input_1 % input_2 ;
> > +  result_imaxdiv = imaxdiv(input_1, input_2) ;
> ditto
>
> > +  rtems_test_assert( result_imaxdiv.quot == result_exp.quot &&
> > +  result_imaxdiv.rem == result_exp.rem );
> indent nested line
>
> https://docs.rtems.org/branches/master/eng/coding-80cols.html#breaking-long-lines
>
> > +
> >    /* Test for strtoimax  */
> >    puts( "\nstrtoimax Testcases...." );
> >    puts( "Valid Inputs - Positive Number" );
> > @@ -83,7 +102,7 @@ rtems_task Init(rtems_task_argument ignored)
> >    rtems_test_assert( result_strtoimax == -123 );
> >
> >    puts( "Final string pointed by endptr" );
> > -  rtems_test_assert( endptr1 == ( nptr1_n + 4 ) );
> > +  rtems_test_assert( endptr1 == ( nptr1_n + 4 ) );
> >
> >    puts( "Valid Input - Positive Number - Number out of Range" );
> >    result_strtoimax = strtoimax( nptr1_p_errange, &endptr1, base );
> > diff --git a/testsuites/psxtests/psxinttypes01/psxinttypes01.doc
> b/testsuites/psxtests/psxinttypes01/psxinttypes01.doc
> > index 19f63af34b..499ef0c72c 100644
> > --- a/testsuites/psxtests/psxinttypes01/psxinttypes01.doc
> > +++ b/testsuites/psxtests/psxinttypes01/psxinttypes01.doc
> > @@ -1,4 +1,4 @@
> > -This File describes the concepts tested by this test suite.
> > +This File describes the concepts tested by this test suite.
> >
> >  inttypes.h - fixed size integer types
> >
> > @@ -37,3 +37,11 @@ test suite name: PSXINTTYPE 01
> >         - checks for output for string having a negative number - Number
> Out of Range
> >         - checks for final string pointed by endptr
> >         - checks for output for invalid argument - Invalid Base
> > +
> > +- Checks for imaxabs Testcases
> > +       - checks for output with an input with any negative number
> > +       - checks for output with an input with any positive number
> > +
> > +- Checks for imaxdiv Testcases
> > +       -checks for the output quotient and remainder with input with
> positive numbers
> space needed between -checks
>
> > +
> > --
> > 2.17.1
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20200403/b8b4f653/attachment-0001.html>