AW: [PATCH v4 3/3] i386: Port to RTEMS

[Jan.Sommer at dlr.de]

> -----Ursprüngliche Nachricht-----
> Von: Sebastian Huber [mailto:sebastian.huber at embedded-brains.de]
> Gesendet: Mittwoch, 15. April 2020 09:23
> An: Sommer, Jan; devel at rtems.org
> Betreff: Re: [PATCH v4 3/3] i386: Port to RTEMS
> 
> On 09/04/2020 15:56, Jan Sommer wrote:
> 
> > - Update imported files to compile rtems-libbsd for i386 based BSPs
> > ---
> >   freebsd-org                                  |    2 +-
> >   freebsd/sbin/sysctl/sysctl.c                 |    8 +
> >   freebsd/sys/dev/pci/pci_pci.c                |    2 +
> >   freebsd/sys/i386/i386/legacy.c               |  381 ---------
> >   freebsd/sys/i386/include/machine/cpufunc.h   |    2 +
> >   freebsd/sys/i386/include/machine/legacyvar.h |   63 --
> >   freebsd/sys/kern/subr_gtaskqueue.c           |    4 +
> Looks good.

Does that ok include the deactivation of the BSD_ASSERT for i386 as well?
I am not that deep in the FreeBSD internals, yet, so I have no reliable gut feeling for those kind of changes.

> >   freebsd/sys/net/iflib.c                      |   24 +
> Please move this to a separate commit with a reason for the change.
Ok.

> >   freebsd/sys/sys/callout.h                    |    6 +
> 
> Please move this to a separate commit with a reason for the change.
>
Ok.
 
> >   rtemsbsd/i386/include/machine/clock.h        |    2 +
> >   rtemsbsd/include/rtems/bsd/local/opt_acpi.h  |    0
> 
> >   rtemsbsd/include/x86/legacyvar.h             |    1 +
> >   rtemsbsd/include/x86/specialreg.h            | 1074
> ++++++++++++++++++++++++++
> >   rtemsbsd/include/x86/x86_var.h               |  156 ++++
> Where do these files come from?

Originally from freebsd-org/sys/x86/include . 
However, I just noticed that with the path-mappings feature it is now pretty easy to solve that with header indirection.
In the next version I will add the files to libbsd.py and add here only a oneliner.
That should be more future proof.