[PATCH rtems-libbsd v2 12/14] ehci_imx: Add to build.

Christian Mauderer christian.mauderer at embedded-brains.de
Thu Apr 16 07:11:50 UTC 2020


Hello Vijay,

On 16/04/2020 09:04, Vijay Kumar Banerjee wrote:
> Hi Christian,
> 
> I'm not able to build libbsd with this patch. I'm getting the following
> error:
> ```
> ../../freebsd/sys/dev/usb/controller/ehci_imx.c:70:10: fatal error:
> arm/freescale/imx/imx_ccmvar.h: No such file or directory
>  #include <arm/freescale/imx/imx_ccmvar.h>
> ```
> From git blame I got to know that this file was introduced by the commit
> from this patch.
> Am I missing something or is it really a bug?

Thanks for the report. On what BSP and which exact commit did you try to
build? I had no trouble building the patch set from a clean checkout
yesterday before committing it.

> 
> Sorry for commenting on the patch that has already been committed,
> please let me know of
> the preferred way to comment on a commit if this is not the right way.

No problem. That's exactly the right way to do it. If there is a bug it
has to be solved and everyone should know that someone is having a look
at it.

Best regards

Christian

> 
> 
> Best regards,
> Vijay
> On Tue, Apr 14, 2020 at 8:21 PM Christian Mauderer
> <christian.mauderer at embedded-brains.de
> <mailto:christian.mauderer at embedded-brains.de>> wrote:
> 
>     ---
>      libbsd.py                            | 2 ++
>      rtemsbsd/include/bsp/nexus-devices.h | 5 +++++
>      2 files changed, 7 insertions(+)
> 
>     diff --git a/libbsd.py b/libbsd.py
>     index 4f8fb4d2..ed6493b2 100644
>     --- a/libbsd.py
>     +++ b/libbsd.py
>     @@ -5028,6 +5028,8 @@ class imx(builder.Module):
>              self.addKernelSpaceSourceFiles(
>                  [
>                      'sys/arm/freescale/imx/imx6_ccm.c',
>     +                'sys/arm/freescale/imx/imx6_usbphy.c',
>     +                'sys/dev/usb/controller/ehci_imx.c',
>                  ],
>                  mm.generator['source']()
>              )
>     diff --git a/rtemsbsd/include/bsp/nexus-devices.h
>     b/rtemsbsd/include/bsp/nexus-devices.h
>     index 0a210bd9..d2ceab8e 100644
>     --- a/rtemsbsd/include/bsp/nexus-devices.h
>     +++ b/rtemsbsd/include/bsp/nexus-devices.h
>     @@ -128,6 +128,11 @@ RTEMS_BSD_DEFINE_NEXUS_DEVICE(ofwbus, 0, 0, NULL);
>      SYSINIT_DRIVER_REFERENCE(simplebus, ofwbus);
> 
>      SYSINIT_DRIVER_REFERENCE(ccm, simplebus);
>     +SYSINIT_DRIVER_REFERENCE(ehci, simplebus);
>     +SYSINIT_DRIVER_REFERENCE(usbphy, simplebus);
>     +SYSINIT_DRIVER_REFERENCE(usbus, ehci);
>     +RTEMS_BSD_DRIVER_USB;
>     +RTEMS_BSD_DRIVER_USB_MASS;
> 
>      SYSINIT_DRIVER_REFERENCE(ffec, simplebus);
>      SYSINIT_DRIVER_REFERENCE(ukphy, miibus);
>     -- 
>     2.16.4
> 
>     _______________________________________________
>     devel mailing list
>     devel at rtems.org <mailto:devel at rtems.org>
>     http://lists.rtems.org/mailman/listinfo/devel
> 

-- 
--------------------------------------------
embedded brains GmbH
Herr Christian Mauderer
Dornierstr. 4
D-82178 Puchheim
Germany
email: christian.mauderer at embedded-brains.de
Phone: +49-89-18 94 741 - 18
Fax:   +49-89-18 94 741 - 08
PGP: Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.


More information about the devel mailing list