GSoC 2020: Final Report (Beagle BSP: Add FDT based initialization)
Gedare Bloom
gedare at rtems.org
Sun Aug 30 15:16:31 UTC 2020
looks great
On Sun, Aug 30, 2020 at 6:55 AM Christian Mauderer <oss at c-mauderer.de> wrote:
>
> On 30/08/2020 14:38, Niteesh G. S. wrote:
> > Hello,
> >
> > On Sun, Aug 30, 2020 at 4:12 PM Christian Mauderer <oss at c-mauderer.de
> > <mailto:oss at c-mauderer.de>> wrote:
> >
> > Hello Niteesh,
> >
> > On 30/08/2020 08:58, Niteesh G. S. wrote:
> > > Hello,
> > >
> > > I have updated the blog to contain the links to the commits
> > > instead of the branches. Please have a look again.
> > > https://gs-niteesh.github.io/finalreport/
> >
> > >From my point of view, it looks good now. You missed the commit
> > with the
> > refactored i2c driver:
> >
> > Sorry about that. I fixed this.
> >
> > https://github.com/gs-niteesh/rtems/commit/be9bd605c40cf7cbcf3f527054fdbab2af39f52a
> >
> > But if you don't have time left it's not a problem if it isn't there.
> >
> > The Submission guidelines tell that "It must be easy to identify the
> > work you have done." From my point of view that was already quite clear
> > because the commits are all on top of the final branch. But Gedare is of
> > course right: Linking every commit is a bit more clear.
> >
> >
> > > And sorry to disturb on the weekend, but we have only about
> > > a day left before the submission deadline, so I request
> > > everyone to please take a look and let me know if you would
> > > like to change anything.
> >
> > No problem for disturbing in this case. Don't miss your deadline. It's
> > better to submit something that is not perfect than not submitting
> > anything. We would have no possibility to fix a missed submission.
> >
> >
> > I have to submit it before tomorrow 11:30 PM IST. I'll leave it tonight
> > for others to comment and will fill it tomorrow morning.
>
> Be really careful to not miss a deadline. Again: We have no chance of
> fixing a missed deadline.
>
> Best regards
>
> Christian
>
> >
> > Thanks,
> > Niteesh.
> >
> >
> > Best regards
> >
> > Christian
> >
> > >
> > > Thanks,
> > > Niteesh.
> > >
> > > On Sun, Aug 30, 2020 at 2:24 AM Gedare Bloom <gedare at rtems.org
> > <mailto:gedare at rtems.org>
> > > <mailto:gedare at rtems.org <mailto:gedare at rtems.org>>> wrote:
> > >
> > > On Sat, Aug 29, 2020 at 8:31 AM Christian Mauderer
> > > <oss at c-mauderer.de <mailto:oss at c-mauderer.de>
> > <mailto:oss at c-mauderer.de <mailto:oss at c-mauderer.de>>> wrote:
> > > >
> > > >
> > > >
> > > > On 29/08/2020 15:04, Niteesh G. S. wrote:
> > > > > Hello,
> > > > > On Sat, Aug 29, 2020 at 2:54 PM Christian Mauderer
> > > <oss at c-mauderer.de <mailto:oss at c-mauderer.de>
> > <mailto:oss at c-mauderer.de <mailto:oss at c-mauderer.de>>
> > > > > <mailto:oss at c-mauderer.de <mailto:oss at c-mauderer.de>
> > <mailto:oss at c-mauderer.de <mailto:oss at c-mauderer.de>>>> wrote:
> > > > >
> > > > > Hello Niteesh
> > > > >
> > > > > On 29/08/2020 11:22, Niteesh G. S. wrote:
> > > > > > On Sat, Aug 29, 2020 at 1:02 PM Christian Mauderer
> > > > > <oss at c-mauderer.de <mailto:oss at c-mauderer.de>
> > <mailto:oss at c-mauderer.de <mailto:oss at c-mauderer.de>>
> > > <mailto:oss at c-mauderer.de <mailto:oss at c-mauderer.de>
> > <mailto:oss at c-mauderer.de <mailto:oss at c-mauderer.de>>>
> > > > > > <mailto:oss at c-mauderer.de <mailto:oss at c-mauderer.de>
> > <mailto:oss at c-mauderer.de <mailto:oss at c-mauderer.de>>
> > > <mailto:oss at c-mauderer.de <mailto:oss at c-mauderer.de>
> > <mailto:oss at c-mauderer.de <mailto:oss at c-mauderer.de>>>>> wrote:
> > > > > >
> > > > > > On 29/08/2020 05:57, Niteesh G. S. wrote:
> > > > > > > On Sat, Aug 29, 2020 at 4:19 AM Gedare Bloom
> > > > > <gedare at rtems.org <mailto:gedare at rtems.org>
> > <mailto:gedare at rtems.org <mailto:gedare at rtems.org>>
> > > <mailto:gedare at rtems.org <mailto:gedare at rtems.org>
> > <mailto:gedare at rtems.org <mailto:gedare at rtems.org>>>
> > > > > > <mailto:gedare at rtems.org
> > <mailto:gedare at rtems.org> <mailto:gedare at rtems.org
> > <mailto:gedare at rtems.org>>
> > > <mailto:gedare at rtems.org <mailto:gedare at rtems.org>
> > <mailto:gedare at rtems.org <mailto:gedare at rtems.org>>>>
> > > > > > > <mailto:gedare at rtems.org
> > <mailto:gedare at rtems.org> <mailto:gedare at rtems.org
> > <mailto:gedare at rtems.org>>
> > > <mailto:gedare at rtems.org <mailto:gedare at rtems.org>
> > <mailto:gedare at rtems.org <mailto:gedare at rtems.org>>>
> > > > > <mailto:gedare at rtems.org <mailto:gedare at rtems.org>
> > <mailto:gedare at rtems.org <mailto:gedare at rtems.org>>
> > > <mailto:gedare at rtems.org <mailto:gedare at rtems.org>
> > <mailto:gedare at rtems.org <mailto:gedare at rtems.org>>>>>> wrote:
> > > > > > >
> > > > > > > Are "Links to commits" 1-4 all the code
> > you (are
> > > > > claiming you)
> > > > > > wrote?
> > > > > > > I just want to make sure. It looks fine to me.
> > > > > > >
> > > > > > > Yes, all the code in the commits is written by me.
> > > > > >
> > > > > > I think maybe "Links to branches" would be a better
> > > title. It
> > > > > is not a
> > > > > > single commit each but a few commits. Alternative
> > > would be to
> > > > > add links
> > > > > > to each commit.
> > > > > >
> > > > > >
> > > > > > I have changed the title to "Links to branches".
> > Should I
> > > also add
> > > > > links
> > > > > > to the commits that were made in each phase at the
> > end of the
> > > > > summary of
> > > > > > each phase?
> > > > > >
> > > > >
> > > > > If you want, you can do that.
> > > > >
> > > > >
> > > > > I did try that but it didn't work out well, especially
> > with the
> > > OFW commit.
> > > > > Since I don't have the old commit I either had to leave that
> > > commit out
> > > > > in the first phase or I had to post the newer commit in the
> > > first phase
> > > > > itself which actually should in the last phase. So I
> > decided to
> > > avoid adding
> > > > > the commits and just leave it out with the branches.
> > > >
> > > > That's OK too. Like I said: Main target was that it's clear
> > that you
> > > > don't have four commits but a bit more.
> > > >
> > >
> > > Oh, I'm sorry I didn't notice this. We actually do want it to be
> > > distinctly your commits. Since you have commits that are older
> > than
> > > this GSoC in rtems, you can't use the author filtering feature
> > >
> > (https://github.com/gs-niteesh/rtems/commits/beagle-rtems6-pinmux-18-aug?author=gs-niteesh)
> > > so you'll probably need to generate the links to each commit.
> > >
> > > This is something required by Google.
> > >
> > > > >
> > > > >
> > > > > The main point of that change was to highlight that
> > it's not
> > > 4 commits
> > > > > but a bit more.
> > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > It has been quite a bit of back and forth during
> > this GSoC
> > > > > project so I
> > > > > > think the result is quite OK.
> > > > > >
> > > > > > Best regards
> > > > > >
> > > > > > Christian
> > > > > >
> > > > > > >
> > > > > > > On Fri, Aug 28, 2020 at 12:07 PM Niteesh G. S.
> > > > > > <niteesh.gs at gmail.com
> > <mailto:niteesh.gs at gmail.com> <mailto:niteesh.gs at gmail.com
> > <mailto:niteesh.gs at gmail.com>>
> > > <mailto:niteesh.gs at gmail.com <mailto:niteesh.gs at gmail.com>
> > <mailto:niteesh.gs at gmail.com <mailto:niteesh.gs at gmail.com>>>
> > > > > <mailto:niteesh.gs at gmail.com
> > <mailto:niteesh.gs at gmail.com> <mailto:niteesh.gs at gmail.com
> > <mailto:niteesh.gs at gmail.com>>
> > > <mailto:niteesh.gs at gmail.com <mailto:niteesh.gs at gmail.com>
> > <mailto:niteesh.gs at gmail.com <mailto:niteesh.gs at gmail.com>>>>
> > > > > > > <mailto:niteesh.gs at gmail.com
> > <mailto:niteesh.gs at gmail.com>
> > > <mailto:niteesh.gs at gmail.com <mailto:niteesh.gs at gmail.com>>
> > > > > <mailto:niteesh.gs at gmail.com
> > <mailto:niteesh.gs at gmail.com> <mailto:niteesh.gs at gmail.com
> > <mailto:niteesh.gs at gmail.com>>>
> > > <mailto:niteesh.gs at gmail.com <mailto:niteesh.gs at gmail.com>
> > <mailto:niteesh.gs at gmail.com <mailto:niteesh.gs at gmail.com>>
> > > > > <mailto:niteesh.gs at gmail.com
> > <mailto:niteesh.gs at gmail.com> <mailto:niteesh.gs at gmail.com
> > <mailto:niteesh.gs at gmail.com>>>>>>
> > > > > > wrote:
> > > > > > > >
> > > > > > > > Hello,
> > > > > > > >
> > > > > > > > I have prepared my final report for my
> > > project. You
> > > > > can have a
> > > > > > > look at it
> > > > > > > > here
> > > https://gs-niteesh.github.io/finalreport/. Please
> > > > > kindly
> > > > > > > review the report.
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > > Niteesh.
> > > > > > >
> > > > > > >
> > > > > > > _______________________________________________
> > > > > > > devel mailing list
> > > > > > > devel at rtems.org <mailto:devel at rtems.org>
> > <mailto:devel at rtems.org <mailto:devel at rtems.org>>
> > > <mailto:devel at rtems.org <mailto:devel at rtems.org>
> > <mailto:devel at rtems.org <mailto:devel at rtems.org>>>
> > > > > <mailto:devel at rtems.org <mailto:devel at rtems.org>
> > <mailto:devel at rtems.org <mailto:devel at rtems.org>>
> > > <mailto:devel at rtems.org <mailto:devel at rtems.org>
> > <mailto:devel at rtems.org <mailto:devel at rtems.org>>>>
> > > > > > > http://lists.rtems.org/mailman/listinfo/devel
> > > > > > >
> > > > > >
> > > > >
> > >
> >
More information about the devel
mailing list