[PATCH] eng: Rework file template section

[Chris Johns]

On 19/2/20 7:03 pm, Sebastian Huber wrote:
> On 19/02/2020 08:54, Chris Johns wrote:
>>> +Check if the top-level :file:`COPYING` file needs an update.
>> What needs to be updated? I think there needs to more detail here, ie add your
>> name etc.
> 
> What about:
> 
> Check the top-level :file:`COPYING` file.  If you are a new copyright holder,
> then add yourself to the top of the list.  If your last year of a substantial
> contribution changed, then please update your copyright line.

Prefect.

> 
> [...]
> 
> 
>>> -.. COMMENT: TBD - TBD Add link to license requirements section and show
>>> variant licenses.
>>> +    /* Definitions, etc. */
>>>
>> I think "<FIRST YEAR>", "<LAST YEAR>" and "<COPYRIGHT HOLDER>" need to be
>> explained. For example "Use your real name, that is your legal name." or "Use a
>> name and/or email address" or something else.
> 
> This is explained in the "Copyright and License Comment Block" section. Should I
> reference this section? For example:
> 
> For the <FIRST YEAR>, <LAST YEAR>, and <COPYRIGHT HOLDER> placeholders see
> :ref:`FileHeaderCopyright`.
> 

Yes please.

Thanks
Chris