[PATCH 02/21] score: Simplify thread stack allocation

Sebastian Huber sebastian.huber at embedded-brains.de
Fri Jan 3 05:58:39 UTC 2020


On 02/01/2020 18:34, Gedare Bloom wrote:
>> diff --git a/cpukit/score/src/threadstackallocate.c b/cpukit/score/src/threadstackallocate.c
>> index fd89d7f07f..722de7bfd6 100644
>> --- a/cpukit/score/src/threadstackallocate.c
>> +++ b/cpukit/score/src/threadstackallocate.c
>> @@ -1,11 +1,11 @@
>>   /**
>>    * @file
>> - *
>> + *
>> + * @ingroup RTEMSScoreStack
>> + *
>>    * @brief Stack Allocate Helper
>> - * @ingroup RTEMSScoreThread
>>    */
>>
>> -
>>   /*
>>    *  COPYRIGHT (c) 1989-2010.
>>    *  On-Line Applications Research Corporation (OAR).
>> @@ -19,28 +19,10 @@
>>   #include "config.h"
>>   #endif
>>
>> -#include <rtems/score/threadimpl.h>
>>   #include <rtems/score/stackimpl.h>
>>   #include <rtems/config.h>
>>
>> -size_t _Thread_Stack_Allocate(
>> -  Thread_Control *the_thread,
>> -  size_t          stack_size
>> -)
>> +void *_Stack_Allocate( size_t stack_size )
> The function is in a new namespace. Should the change reflect in filename too?

I would avoid renaming files to make it a bit easier to track the 
history of functions.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.


More information about the devel mailing list