[PATCH 01/16] rtems: Remove _RTEMS_version

Chris Johns chrisj at rtems.org
Tue Jul 14 04:20:13 UTC 2020


On 13/7/20 4:54 pm, Sebastian Huber wrote:
> On 13/07/2020 08:51, Sebastian Huber wrote:
>> diff --git a/bsps/shared/rtems-version.c b/bsps/shared/rtems-version.c
>> index 99b98966e6..26f7a5731a 100644
>> --- a/bsps/shared/rtems-version.c
>> +++ b/bsps/shared/rtems-version.c
>> @@ -25,7 +25,7 @@
>>   #error "Missing RTEMS_BSP"
>>   #endif
>>   -const char _RTEMS_version[] =
>> +const char _Version_String[] =
> 
> Now I think that renaming this variable is unnecessary. We should just move the
> declaration and keep the name as is.

Yes. Being a static executable we need to preserve an RTEMS namespace by
prefixing RTEMS in some form. I get _ is reserved but I am not sure many people
know this and respect this. It also groups RTEMS items in sorted symbol lists.

Chris


More information about the devel mailing list