[PATCH v2 2/2] break fenv.c file to function files

[Eshan Dhawan]

> On 24-Jul-2020, at 11:06 AM, Sebastian Huber <sebastian.huber at embedded-brains.de> wrote:
> 
> On 24/07/2020 07:35, Eshan Dhawan wrote:
> 
>>>> -#include "../../fenv/fenv_stub.c"
>>>> +#include <fenv.h>
>>>> +
>>>> +int feclearexcept(int excepts)
>>>> +{
>>>> +#ifndef __SOFTFP__
>>>> +    fexcept_t __fpsr;
>>>> +
>>>> +    vmrs_fpscr(__fpsr);
>>>> +    __fpsr &= ~excepts;
>>>> +    vmsr_fpscr(__fpsr);
>>>> +#endif
>>>> +    return (0);
>>>> +}
>>> Where is vmrs_fpscr() defined? Please add a header file for this, for example
>>> 
>> I defined it in machine/arm/sys/fenv.h
>> Apologies I forgot to add the file in the patch
>> I will resend V2 with the correct message and file
> I would not place this define in <sys/fenv.h> since it is an implementation detail.
<Sys/fenv.h> is the machine specific fenv header so AFAIK any machine specific or implementation specific information or defines do there 
That’s the pattern being followed in the older implementations as well