[PATCH] bsps/lm32: Use shared <bsp/irq.h>

[Gedare Bloom]

On Thu, Jul 30, 2020 at 12:40 PM Gedare Bloom <gedare at rtems.org> wrote:
>
> I think most of the BSPs have the pattern of <board>/include/bsp/irq.h
>
> What is unusual about lm32 is that it has a shared one at include/bsp/irq.h
>
> I only see this in BSP directories that have one bsp. I think the
> shared irq.h should instead be removed/renamed.
>

Only i386 and x86_64 have this ./include/bsp/irq.h from its top level

> On Thu, Jul 30, 2020 at 11:35 AM Sebastian Huber
> <sebastian.huber at embedded-brains.de> wrote:
> >
> > Having a duplicate header with the shared includes is a build system
> > inconsistency.  You may use one header file to build the libraries and
> > another one is installed (overwriting the other).
> >
> > Update #3269.
> > ---
> >  bsps/lm32/lm32_evr/headers.am         | 4 ----
> >  bsps/lm32/lm32_evr/include/bsp/irq.h  | 1 -
> >  bsps/lm32/milkymist/headers.am        | 4 ----
> >  bsps/lm32/milkymist/include/bsp/irq.h | 1 -
> >  4 files changed, 10 deletions(-)
> >  delete mode 100644 bsps/lm32/lm32_evr/include/bsp/irq.h
> >  delete mode 100644 bsps/lm32/milkymist/include/bsp/irq.h
> >
> > diff --git a/bsps/lm32/lm32_evr/headers.am b/bsps/lm32/lm32_evr/headers.am
> > index 2c9d86fd68..213b66effe 100644
> > --- a/bsps/lm32/lm32_evr/headers.am
> > +++ b/bsps/lm32/lm32_evr/headers.am
> > @@ -5,7 +5,3 @@ include_HEADERS += ../../../../../../bsps/lm32/lm32_evr/include/bsp.h
> >  include_HEADERS += include/bspopts.h
> >  include_HEADERS += ../../../../../../bsps/lm32/lm32_evr/include/system_conf.h
> >  include_HEADERS += ../../../../../../bsps/lm32/lm32_evr/include/tm27.h
> > -
> > -include_bspdir = $(includedir)/bsp
> > -include_bsp_HEADERS =
> > -include_bsp_HEADERS += ../../../../../../bsps/lm32/lm32_evr/include/bsp/irq.h
> > diff --git a/bsps/lm32/lm32_evr/include/bsp/irq.h b/bsps/lm32/lm32_evr/include/bsp/irq.h
> > deleted file mode 100644
> > index 8a97d7a1b0..0000000000
> > --- a/bsps/lm32/lm32_evr/include/bsp/irq.h
> > +++ /dev/null
> > @@ -1 +0,0 @@
> > -#include <bsp/irq-default.h>
> > diff --git a/bsps/lm32/milkymist/headers.am b/bsps/lm32/milkymist/headers.am
> > index 30df486e81..1bd114fba1 100644
> > --- a/bsps/lm32/milkymist/headers.am
> > +++ b/bsps/lm32/milkymist/headers.am
> > @@ -5,7 +5,3 @@ include_HEADERS += ../../../../../../bsps/lm32/milkymist/include/bsp.h
> >  include_HEADERS += include/bspopts.h
> >  include_HEADERS += ../../../../../../bsps/lm32/milkymist/include/system_conf.h
> >  include_HEADERS += ../../../../../../bsps/lm32/milkymist/include/tm27.h
> > -
> > -include_bspdir = $(includedir)/bsp
> > -include_bsp_HEADERS =
> > -include_bsp_HEADERS += ../../../../../../bsps/lm32/milkymist/include/bsp/irq.h
> > diff --git a/bsps/lm32/milkymist/include/bsp/irq.h b/bsps/lm32/milkymist/include/bsp/irq.h
> > deleted file mode 100644
> > index 8a97d7a1b0..0000000000
> > --- a/bsps/lm32/milkymist/include/bsp/irq.h
> > +++ /dev/null
> > @@ -1 +0,0 @@
> > -#include <bsp/irq-default.h>
> > --
> > 2.26.2
> >
> > _______________________________________________
> > devel mailing list
> > devel at rtems.org
> > http://lists.rtems.org/mailman/listinfo/devel