[PATCH] waf: Change the test configure check for libdebugger to it's lib

Chris Johns chrisj at rtems.org
Thu Mar 5 23:09:02 UTC 2020


On 2020-03-06 00:58, Gedare Bloom wrote:
> On Thu, Mar 5, 2020 at 3:23 AM <chrisj at rtems.org> wrote:
>>
>> From: Chris Johns <chrisj at rtems.org>
>>
>> - Add support for a 'test-if-library'
>>
>> - Use rtems_waf's 'test_application()' fragment in the check_cc
>>    call
>>
>> Closes #3948
>> ---
>>   builder.py    | 30 +++++++++++++++++++++++++++---
>>   libbsd.py     |  4 ++--
>>   waf_libbsd.py | 28 +++++++++++++++++++++-------
>>   3 files changed, 50 insertions(+), 12 deletions(-)
>>
>> diff --git a/builder.py b/builder.py
>> index 2921bab8..0eda461f 100755
>> --- a/builder.py
>> +++ b/builder.py
>> @@ -505,15 +505,17 @@ class SourceFileIfHeaderComposer(SourceFileFragmentComposer):
>>
>>   class TestFragementComposer(BuildSystemFragmentComposer):
>>
>> -    def __init__(self, testName, fileFragments, runTest = True, netTest = False, extraLibs = []):
>> +    def __init__(self, testName, fileFragments, configTest = None, runTest = True, netTest = False, extraLibs = []):
> 
> I'm trying to pay more attention to the Python code. This method
> definition is overlong.

In isolation it is but I am only following what is used in this code 
rather than changing it in small pieces. For example just above ...

https://git.rtems.org/rtems-libbsd/tree/builder.py#n508

Chris


More information about the devel mailing list