[PATCH 1/2] Convert host checking to pytest.

Gedare Bloom gedare at rtems.org
Mon Mar 16 03:09:55 UTC 2020


On Sun, Mar 15, 2020 at 5:54 PM Amar Takhar <amar at rtems.org> wrote:
>
> On 2020-03-15 17:26 -0600, Gedare Bloom wrote:
>
> > Make blank lines consistent, 1 or 2, between top-level definitions. (I
> > know, we still haven't settled on a style, but let's aim for
> > consistency.)
>
> Okay.
>
>
> > I think all imports should go at the top?
>
> This is scoped it only runs under certain conditions extremely common in Python.
> It's good practice as well as there's no point in loading a module that isn't
> used all of the time.  Also, it makes for far clearer code as you know the
> module is only used for that snippet.
>
Alright. I think this may need to be specially defined in style guide.

I believe Google guide makes some restrictions on imports. I'm not
enough Python expert to know, but I really think with the amount of
Python code that is expected to come through, we need to decide on
these things sooner than later.

>
> Amar.
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel


More information about the devel mailing list