[PATCH 2/3] testsuite: User input define added

[Sebastian Huber]

On 31/03/2020 11:56, Chris Johns wrote:

> On 2020-03-31 19:57, Moyano, Gabriel wrote:
>> diff --git a/testsuite/arphole/test_main.c 
>> b/testsuite/arphole/test_main.c
>> index 19d67b89..45a28cc0 100644
>> --- a/testsuite/arphole/test_main.c
>> +++ b/testsuite/arphole/test_main.c
>> @@ -54,6 +54,7 @@
>>   #include <rtems/bsd/util.h>
>>     #define TEST_NAME "LIBBSD ARP HOLE"
>> +#define TEST_STATE_USER_INPUT 1
>
> In rtems.git these test states are defined on the compiler command 
> line. The user input state is OK to define in the code but it gets 
> more difficult with the others to manage them in the code and so I am 
> wondering how we manage the other states in libbsd? And if we manage 
> those in the build system then why manage this one? 

Why should this define move to the build system of libbsd. It is a 
property of the test if it is interactive or not.

In RTEMS we have it in the build system since you can set tests to 
expected fail or disable them per BSP. I am not sure if we need this 
extra complexity for libbsd right now. We could at some point in time 
use the same build system for RTEMS and libbsd.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20200331/1f265c46/attachment-0001.html>