[PATCH 0/2] Source Builder: Fix UnicodeDecodeError build hang

[Anders Montonen]

Hi,

> On 7 May 2020, at 5:10, Chris Johns <chrisj at rtems.org> wrote:
> 
> On 7/5/20 9:37 am, Anders Montonen wrote:
>> This patch fixes the UnicodeDecodeError that randomly caused source
>> builder to hang.
>> 
>> In my testing, there was no difference in performance at least under
>> Python 3.
> 
> Have you tested python 2?

Not beyond verifying that the tests in the file pass. I have deliberately not installed Python 2 on the systems I’ve been testing on, but I suppose I could spin up a sacrificial VM.

> I would like to explore this change on master after we branch for 5 and if the
> testing on master proves stable we can look at merging it on the 5 branch for
> 5.2. Is this approach OK with you?

Of course.

Regards,
Anders