[PATCH] riscv: Mark htif_console_handler in htif.h as extern

[Gedare Bloom]

On Thu, May 21, 2020 at 6:36 PM Hesham Almatary
<heshamelmatary at gmail.com> wrote:
>
> On Mon, 18 May 2020 at 06:10, Gedare Bloom <gedare at rtems.org> wrote:
> >
> > you can push this one. I don't know if there are others?
>
> Thanks! Yeah, just one more here [1] but it's not vital/used yet.
>
If it's dead code, hold off until 6, thanks

> [1] https://lists.rtems.org/pipermail/devel/2020-May/059772.html
> >
> > On Sun, May 17, 2020 at 7:06 PM Hesham Almatary
> > <heshamelmatary at gmail.com> wrote:
> > >
> > >
> > >
> > > On Sun, 17 May 2020 at 23:45, Joel Sherrill <joel at rtems.org> wrote:
> > >>
> > >> I hope you have committed these by now. :)
> > >
> > > Not yet, was waiting for approval. Shall I wait for the release first?
> > >>
> > >>
> > >> On Thu, May 7, 2020 at 3:14 PM <heshamelmatary at gmail.com> wrote:
> > >>>
> > >>> From: Hesham Almatary <Hesham.Almatary at cl.cam.ac.uk>
> > >>>
> > >>> It is defined in htif.c
> > >>> ---
> > >>>  bsps/riscv/riscv/include/dev/serial/htif.h | 2 +-
> > >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> > >>>
> > >>> diff --git a/bsps/riscv/riscv/include/dev/serial/htif.h b/bsps/riscv/riscv/include/dev/serial/htif.h
> > >>> index b0d83652b..4b16d8746 100644
> > >>> --- a/bsps/riscv/riscv/include/dev/serial/htif.h
> > >>> +++ b/bsps/riscv/riscv/include/dev/serial/htif.h
> > >>> @@ -45,7 +45,7 @@ void htif_console_putchar(rtems_termios_device_context *base, char c);
> > >>>
> > >>>  int htif_console_getchar(rtems_termios_device_context *base);
> > >>>
> > >>> -const rtems_termios_device_handler htif_console_handler;
> > >>> +extern const rtems_termios_device_handler htif_console_handler;
> > >>>
> > >>>  #ifdef __cplusplus
> > >>>  }
> > >>> --
> > >>> 2.25.1
> > >>>
> > >>> _______________________________________________
> > >>> devel mailing list
> > >>> devel at rtems.org
> > >>> http://lists.rtems.org/mailman/listinfo/devel
> > >
> > > --
> > > Hesham
> > > _______________________________________________
> > > devel mailing list
> > > devel at rtems.org
> > > http://lists.rtems.org/mailman/listinfo/devel
>
>
>
> --
> Hesham