[PATCH v2 7/8] bsps: Add Cortex-A53 LP64 basic BSP

[Kinsey Moore]

-----Original Message-----
From: Sebastian Huber <sebastian.huber at embedded-brains.de> 
Sent: Thursday, October 1, 2020 00:05
To: Kinsey Moore <kinsey.moore at oarcorp.com>; devel at rtems.org
Subject: Re: [PATCH v2 7/8] bsps: Add Cortex-A53 LP64 basic BSP

On 30/09/2020 22:04, Kinsey Moore wrote:
> -----Original Message-----
> From: Sebastian Huber<sebastian.huber at embedded-brains.de>
> Sent: Tuesday, September 29, 2020 06:49
> To: Kinsey Moore<kinsey.moore at oarcorp.com>;devel at rtems.org
> Subject: Re: [PATCH v2 7/8] bsps: Add Cortex-A53 LP64 basic BSP
> 
> On 28/09/2020 17:24, Kinsey Moore wrote:
> 
>> diff --git a/bsps/aarch64/shared/start/linkcmds.base
>> b/bsps/aarch64/shared/start/linkcmds.base
>> new file mode 100644
>> index 0000000000..f67404ab62
>> --- /dev/null
>> +++ b/bsps/aarch64/shared/start/linkcmds.base
>> @@ -0,0 +1,450 @@
>> +/* SPDX-License-Identifier: BSD-2-Clause */
>> +
>> +/**
>> + * @file
>> + *
>> + * @ingroup bsp_linker
>> + *
>> + * @brief Linker command base file.
>> + */
>> +
>> +/*
>> + * Copyright (C) 2020 On-Line Applications Research Corporation 
>> +(OAR)
>> + * Written by Kinsey Moore<kinsey.moore at oarcorp.com>
> This looks like a modified copy of bsps/arm/shared/start/linkcmds.base.
> Are there significant differences or could we share this linker script on arm and aarch64?
> []
> They are similar and could probably share large sections, but a single base linker script is not shareable between arm and aarch64 due to aarch64 multilibs needing different OUTPUT_FORMAT and OUTPUT_ARCH directives as well as having differing setups for their various respective exception stacks.

Can't this be solved via an INCLUDE similar to linkcmds.armv4 and linkcmds.armv7m?

[] 
If 32-bit ARM isn't broken by having the extra SUBALIGN(4) here and there, then they can share a single base include. Otherwise, it will have to be 3 or 4 different includes. I'll have to setup a test environment to see if one of the ARM QEMU BSPs is affected.

Kinsey