[PATCH] score/aarch64: Size saved SP register for ABI

Hesham Almatary heshamelmatary at gmail.com
Thu Oct 22 19:50:31 UTC 2020


On Thu, 22 Oct 2020 at 20:07, Kinsey Moore <kinsey.moore at oarcorp.com> wrote:

> This ensures that the saved SP register is sized appropriately depending
> on the chosen ABI and prevents a warning in the libmisc stack checker.
> ---
>  cpukit/score/cpu/aarch64/include/rtems/score/cpu.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/cpukit/score/cpu/aarch64/include/rtems/score/cpu.h
> b/cpukit/score/cpu/aarch64/include/rtems/score/cpu.h
> index da2140a2a8..b33f6a1c85 100644
> --- a/cpukit/score/cpu/aarch64/include/rtems/score/cpu.h
> +++ b/cpukit/score/cpu/aarch64/include/rtems/score/cpu.h
> @@ -489,7 +489,10 @@ typedef struct {
>  #ifdef AARCH64_MULTILIB_ARCH_V8_ILP32
>    uint32_t _register_lr_top;
>  #endif
> -  uint64_t register_sp;
> +  uintptr_t register_sp;
> +#ifdef AARCH64_MULTILIB_ARCH_V8_ILP32
> +  uint32_t _register_sp_top;

Won’t uintptr_t work here (and for all of the other integer registers) as
well and consequently we get rid of all of such multiarch  ifdefs?


> +#endif
>    void *register_pc;
>  #ifdef AARCH64_MULTILIB_ARCH_V8_ILP32
>    uint32_t _register_pc_top;


-- 
> 2.20.1
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
-- 
Hesham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20201022/6d9bb74c/attachment.html>


More information about the devel mailing list